Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
cad66e5 to
864df69
Compare
after_tool_callback logged every tool result as TOOL_COMPLETED with status OK, including MCP CallToolResult isError payloads and results that carry error_details. Classify those as TOOL_ERROR so status and error_message match on_tool_error_callback. Fixes google#7112 Co-authored-by: Zsanz3 <Zsanz3@users.noreply.github.com>
6cd97b5 to
528b7c9
Compare
|
Thanks for addressing error-bearing results that would otherwise be logged as successful tool calls. The new |
Covers the error_message is None guard on final_response_tool_names so a failed tool does not also emit AGENT_RESPONSE (requested by paulxg12 on google#7114).
|
Thanks @paulxg12 — good catch on the I added a unit test that puts the tool in |
Fixes #7112
Summary
BigQueryAgentAnalyticsPlugin.after_tool_callbackwas logging error-bearing tool results asTOOL_COMPLETED/ OK. It now classifies results withisError/error_detailsasTOOL_ERROR(aligned withon_tool_error_callback).Changes
error_details,isError/is_error; prefer MCPcontent[0].textforerror_messagewhen present_log_eventcovering MCPisErroranderror_detailsTests