Repository navigation
fix(graphql): preserve names for multiple operations in one document - #3546
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use each GraphQL operation's name when one input document contains multiple operations. Apply the source name override only when there is one source with one operation.
Related Issue
Fixes #3532.
Motivation and Context
A document can contain several named queries that share a fragment. The parser already builds a response type for each operation, but the input layer registers every response under the source name when there is only one source file. The second registration fails.
Previous Behaviour / Output
For example, a document with
ViewerQuery,UserQuery, and a sharedUserFieldsfragment fails withInternal error: Trying to add top-level with existing name. This also affects a query and a mutation in the same document.New Behaviour / Output
The document produces separate
ViewerQueryandUserQueryresponse types and converters. A single named or anonymous operation still uses the requested source name. Multiple source files retain their existing operation naming behavior.How Has This Been Tested?
npm run build, all 248 unit tests, andnpm run lintpassed.QUICKTEST=true FIXTURE=graphql-javascript,graphql-typescript CPUs=2 npm run test:fixtures).Screenshots (if appropriate):
Not applicable.
AI disclosure: implementation, tests, and this PR description were produced with OpenAI GPT-6 through Codex. The change was reviewed against the source and verified with the checks listed above.