Repository navigation
fix: drop dataset-specific French sentence replacements - #40
Open
egenthon-cmd wants to merge 2 commits into
Open
egenthon-cmd wants to merge 2 commits into
egenthon-cmd wants to merge 2 commits into
Conversation
Remove bulletins, zaka nino, and c est cher mappings that collapse distinct ASR surface forms. Co-authored-by: Cursor <cursoragent@cursor.com>
Word-level metres→m2 wrongly treated linear metres as area; use sentence rules for carré forms only. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bulletins de salaires→bulletins de salaire,zaka nino→zaccanino, andc est cher→c'est cherfromFRENCH_SENTENCE_REPLACEMENTS.my people doc,releve d heure, compound sports/tech spacing, etc.).These mappings were too dataset-specific and merge genuinely different phrases for WER scoring.
Test plan
uv run pytest tests/e2e -q -k frenchuv run pytest tests/unit/languages -q -k frenchMade with Cursor