Skip to content

Remove unused devDependencies - #4600

Merged
josefs merged 1 commit into
mainfrom
josefs/remove-unused-dependencies
Oct 15, 2026
Merged

josefs merged 1 commit into
mainfrom
josefs/remove-unused-dependencies

Conversation

@josefs

@josefs josefs commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Removes unused devDependencies from extensions/ql-vscode/package.json:

  • @babel/preset-react, @babel/preset-typescript, cosmiconfig: Leftovers from the Storybook 7 upgrade; Storybook now uses Vite (@storybook/react-vite) and Jest uses ts-jest.
  • eslint-plugin-etc: Leftover from .eslintrc.js; unused in eslint.config.mjs.
  • @types/styled-components: styled-components v6 ships its own TypeScript definitions (@types/styled-components is for v5).
  • @typescript-eslint/eslint-plugin: Never imported directly (eslint.config.mjs uses typescript-eslint).

Removes unused devDependencies from extensions/ql-vscode/package.json:
- @babel/preset-react
- @babel/preset-typescript
- @types/styled-components
- @typescript-eslint/eslint-plugin
- cosmiconfig
- eslint-plugin-etc

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@josefs
josefs requested a review from kaspersv October 15, 2026 09:46
@josefs
josefs marked this pull request as ready for review October 15, 2026 09:46
@josefs
josefs requested a review from a team as a code owner October 15, 2026 09:46
Copilot AI max review requested due to automatic review settings October 15, 2026 09:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Usage checks and lockfile validation support the removals, with no blocking regressions identified.

0 open findings

What changed in this PR

Removes six unused direct development dependencies from the CodeQL extension.

Changes:

  • Drops obsolete Babel presets, lint packages, configuration tooling, and redundant type definitions.
  • Updates the lockfile to prune dependencies no longer needed.
File Description
extensions/​ql-vscode/​package.json Removes unused development dependencies.
extensions/​ql-vscode/​package-lock.json Synchronizes declarations and prunes unused packages.
Files not reviewed (1)
  • extensions/ql-vscode/package-lock.json: Generated file

🧠 Review effort: Max


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kaspersv kaspersv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@josefs
josefs merged commit 1f292ed into main Oct 15, 2026
22 checks passed
@josefs
josefs deleted the josefs/remove-unused-dependencies branch October 15, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants