Skip to content

[Outreachy PATCH] diff-delta: use safe integer arithmetic #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poojarysrujith wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Outreachy PATCH] diff-delta: use safe integer arithmetic #2276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions diff-delta.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ struct delta_index * create_delta_index(const void *buf, size_t bufsize)
hmask = hsize - 1;

/* allocate lookup index */
memsize = sizeof(*hash) * hsize +
sizeof(*entry) * entries;
memsize = st_add(st_mult(sizeof(*hash), hsize),
st_mult(sizeof(*entry), entries));
mem = malloc(memsize);
if (!mem)
return NULL;
Expand Down Expand Up @@ -258,9 +258,9 @@ struct delta_index * create_delta_index(const void *buf, size_t bufsize)
* Now create the packed index in array form
* rather than linked lists.
*/
memsize = sizeof(*index)
+ sizeof(*packed_hash) * (hsize+1)
+ sizeof(*packed_entry) * entries;
memsize = st_add3(sizeof(*index),
st_mult(sizeof(*packed_hash), hsize + 1),
st_mult(sizeof(*packed_entry), entries));
mem = malloc(memsize);
if (!mem) {
free(hash);
Expand Down
Loading