Skip to content

feat(solidstart): Serve the managed tunnel on SolidStart v1 - #25423

Draft
logaretm wants to merge 2 commits into
awad/tunnel-react-routerfrom
awad/tunnel-solidstart
Draft

feat(solidstart): Serve the managed tunnel on SolidStart v1#25423
logaretm wants to merge 2 commits into
awad/tunnel-react-routerfrom
awad/tunnel-solidstart

Conversation

@logaretm

@logaretm logaretm commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

SolidStart v1 couldn't serve tunnel: true because Nitro v2 only loads plugins by path, fixed by withSentry registering a plugin that answers tunnel requests from Nitro's request hook.

The tests cover the plugin and its registration, and an e2e tunnel variant checks the tunnel answers while an auth middleware rejects every other POST.

@logaretm
logaretm added this pull request to stack #25201 October 15, 2026 17:36
@logaretm
logaretm force-pushed the awad/tunnel-solidstart branch from 02a533b to 9dd69b3 Compare October 15, 2026 17:44
@github-actions

github-actions Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 30.67 kB +2.66% +794 B 🔺
@sentry/browser - with treeshaking flags 28.54 kB +1.86% +520 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing 28.43 kB +1.81% +504 B 🔺
@sentry/browser (incl. Tracing) 52.86 kB +1.52% +791 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 52.87 kB +1.54% +799 B 🔺
@sentry/browser (incl. Tracing, Profiling) 55.78 kB +1.39% +763 B 🔺
@sentry/browser (incl. Tracing, Replay) 92.59 kB +0.84% +771 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.18 kB +0.62% +496 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 97.31 kB +0.8% +766 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 110.28 kB +0.73% +797 B 🔺
@sentry/browser (incl. Feedback) 48.19 kB +1.69% +799 B 🔺
@sentry/browser (incl. sendFeedback) 35.75 kB +2.33% +812 B 🔺
@sentry/browser (incl. FeedbackAsync) 40.85 kB +2% +800 B 🔺
@sentry/browser (incl. Metrics) 31.66 kB +2.46% +759 B 🔺
@sentry/browser (incl. Logs) 31.94 kB +2.44% +758 B 🔺
@sentry/browser (incl. Metrics & Logs) 32.64 kB +2.62% +831 B 🔺
@sentry/react 32.47 kB +2.44% +772 B 🔺
@sentry/react (incl. Tracing) 55.15 kB +1.41% +766 B 🔺
@sentry/vue 38.82 kB +2.06% +783 B 🔺
@sentry/vue (incl. Tracing) 55.8 kB +1.44% +790 B 🔺
@sentry/svelte 30.7 kB +2.69% +802 B 🔺
@sentry/remix (Remix 3 client bundle) 57.9 kB +1.44% +819 B 🔺
CDN Bundle 32.09 kB +1.41% +445 B 🔺
CDN Bundle (incl. Tracing) 53.05 kB +0.89% +465 B 🔺
CDN Bundle (incl. Logs, Metrics) 34.29 kB +1.34% +452 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 54.99 kB +0.86% +466 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 75.23 kB +0.62% +462 B 🔺
CDN Bundle (incl. Tracing, Replay) 90.72 kB +0.53% +475 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 92.7 kB +0.57% +523 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 96.84 kB +0.46% +438 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.88 kB +0.55% +536 B 🔺
CDN Bundle - uncompressed 94.33 kB +1.23% +1.15 kB 🔺
CDN Bundle (incl. Tracing) - uncompressed 157.17 kB +0.73% +1.13 kB 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.87 kB +1.15% +1.15 kB 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.13 kB +0.71% +1.13 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 230.91 kB +0.5% +1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 277.33 kB +0.42% +1.13 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 283.28 kB +0.41% +1.13 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 291.04 kB +0.4% +1.13 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 296.97 kB +0.39% +1.13 kB 🔺
@sentry/nextjs (client) 57.56 kB +1.35% +764 B 🔺
@sentry/sveltekit (client) 53.28 kB +1.58% +828 B 🔺
@sentry/core/server 41.75 kB +1.53% +629 B 🔺
@sentry/core/browser 13.81 kB - -
@sentry/node 153.12 kB +0.43% +652 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.81 kB - -
@sentry/node - without tracing 95.26 kB +0.7% +653 B 🔺
@sentry/node - without channel injection 131.31 kB +0.48% +619 B 🔺
@sentry/aws-serverless 103.53 kB +0.75% +762 B 🔺
@sentry/cloudflare (withSentry) - minified 212.26 kB +0.8% +1.67 kB 🔺
@sentry/cloudflare (withSentry) 525.91 kB +0.65% +3.38 kB 🔺
@sentry/nextjs/cloudflare (withSentry) - minified 229.94 kB +0.73% +1.67 kB 🔺

View base workflow run

@logaretm
logaretm force-pushed the awad/tunnel-solidstart branch from 9dd69b3 to 1aeffb6 Compare October 15, 2026 18:16
@logaretm
logaretm force-pushed the awad/tunnel-solidstart branch from 1aeffb6 to a191b72 Compare October 15, 2026 18:26
@logaretm
logaretm force-pushed the awad/tunnel-solidstart branch from a191b72 to dc1137c Compare October 15, 2026 18:28
@logaretm

logaretm commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

bugbot run

cursor[bot]
cursor Bot reviewed Oct 15, 2026
View reviewed changes

@cursor cursor Bot left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread dev-packages/e2e-tests/test-applications/solidstart/tests/tunnel.test.ts Outdated
@logaretm
logaretm force-pushed the awad/tunnel-solidstart branch from dc1137c to 76aedc2 Compare October 16, 2026 01:51
@logaretm

logaretm commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

bugbot run

cursor[bot]
cursor Bot reviewed Oct 16, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 76aedc2. Configure here.

@logaretm
logaretm force-pushed the awad/tunnel-solidstart branch from 76aedc2 to 9494c2d Compare October 16, 2026 02:25
@logaretm
logaretm force-pushed the awad/tunnel-solidstart branch from 9494c2d to b33703e Compare October 16, 2026 03:32
@logaretm
logaretm force-pushed the awad/tunnel-solidstart branch from b33703e to b81588b Compare October 16, 2026 04:23
@logaretm
feat(solidstart): Serve the managed tunnel on SolidStart v1
a153ad7 
`withSentry` registers a Nitro v2 plugin that answers tunnel requests from the
`request` hook, before the app's middleware. It goes through `server.plugins`
because vinxi's dev server ignores plugins that Nitro modules add.
@logaretm
test(solidstart): Use the conventions constants in the tunnel tests
73f8123
@logaretm
logaretm force-pushed the awad/tunnel-solidstart branch from b81588b to 73f8123 Compare October 16, 2026 04:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@logaretm