Repository navigation
fix: derive term dates from indexable members - #2350
Merged
Merged
Conversation
Share effective term dates across RSS and sitemap metadata while keeping ordinary page dates and feed selection unchanged. Preserve typed date overrides per field, including zero, and document reserved custom keys. Cover hidden members, resolved overrides, missing dates, branch members and multilingual cache isolation with observable feed/sitemap fixtures.
Treat zero time as absence when deriving term dates and RSS channel maxima, so valid year 0000 values are preserved. Exercise independent field maxima, zero members and typed overrides in generated RSS, sitemap and helper output. Fixes #2348
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
markdumay
enabled auto-merge
November 8, 2026 09:46
Use the existing shell command pattern so the pnpm Windows launcher can run. Retain quoted fixture paths and report spawn errors before checking the exit status.
Collaborator
Author
|
🎉 This PR is included in version 3.52.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hugo derives taxonomy term dates from all members, so a newer noindex member can still advance RSS and sitemap metadata after that member is filtered out. This uses a shared
GetIndexableDatesutility to derive missing term fields from indexable members and applies it in RSS and sitemap output.Typed
time.TimeParamsdate,publishDateandlastmodare per-field overrides, including zero; the README documents that convention. Non-time custom values are ignored. Ordinary-page dates, the native RSS own-Date guard, membership, ordering and limits remain unchanged.Verification: feed fixtures pass 23/23 on Hugo 0.158.0 and 0.169.0, including explicit/typed overrides, zero and pre-zero dates, corresponding fields, branch members and multilingual isolation. Full pinned-runtime tests/builds and minimum-runtime template/language/renderer/feed checks plus root/example builds pass. Independent mutation checks reject guard and date-filter changes; root/example HTML remains byte-identical.
Closes #2348.