Repository navigation
Stage the update's download under a name node --check accepts - #1
Merged
Merged
Conversation
The updater checks the file it downloaded with `node --check` before moving it over itself, and staged it as `wt.<pid>.tmp`: Node refuses an extension it doesn't know, so every update failed. It's `.wt-<pid>-update` now, with no extension, and the smoke test runs `node --check` under that name. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… README CI checks a pull request out detached, so the main worktree has no branch name and `--complete` printed nothing: the smoke test now makes a small repo with a branch and a second worktree, and also checks that a query naming one worktree prints its path. The README keeps the one-line installer as the way in; the manual and npm paths are gone from it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
wt update(and the daily background update) checks its download withnode --checkbefore renaming it over the installed script. It staged the download aswt.<pid>.tmp, and Node refuses an extension it doesn't know (ERR_UNKNOWN_FILE_EXTENSION), so every update failed with "the download doesn't run". A 0.1.0 install can't update itself; it needs the installer run again.What
.wt-<pid>-update, next to the script, with no extension.dist/wtunder that name and runsnode --checkon it.Verified with a copy built as 0.0.1:
wt updatedownloaded 0.1.0 over it, the staging file was gone, and a second run reported it current.🤖 Generated with Claude Code