Repository navigation
fix: refresh tab icon when the window's app resolves late - #591
Open
amrography wants to merge 1 commit into
Open
amrography wants to merge 1 commit into
amrography wants to merge 1 commit into
Conversation
The app for a window was looked up once, when its node was created. If the window tracker had not matched the window yet, the tab kept a fallback app and showed the generic application icon permanently, even after the panel and dock showed the correct one. Re-check the app in render() and replace the icon when it changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app for a window was looked up once, when its node was created. If the window tracker had not matched the window yet, the tab kept a fallback app and showed the generic application icon permanently, even after the panel and dock showed the correct one.
Re-check the app in render() and replace the icon when it changes.