Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10004
On narrow screens (e.g. DevTools embedded in a VS Code side panel, ~330-410px wide) the Network tab's toolbar controls overlapped and the status bar items were clipped past the right edge.
MediaSize.xsthe controls now stack: record, clear and open/save on the first row, then the search field, then the filter field. Wider screens keep the existing single-row layout.MediaSize.xsthe video tutorial link is hidden, and the connection status isFlexibleso it can shrink. This is in the shared status line, so it applies to every screen, not just Network (the overflow reproduced at 330px even with no app connected).Added widget tests at 410px and 330px for the Network controls (no overflow, no overlap between search, filter and open/save) and for the status line (no overflow when embedded).
TODO: before/after screenshots
Pre-launch Checklist
General checklist
///).Issues checklist
contributions-welcomeorgood-first-issuelabel.contributions-welcomeorgood-first-issuelabel. I understand this means my PR might take longer to be reviewed.Tests checklist
Feature-change checklist
packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.