Repository navigation
Fix ANSI log styling - #10028
Merged
Merged
Fix ANSI log styling#10028
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for stripping ANSI escape codes from pretty-printed log details and refactors textSpansFromAnsi to preserve default text styles. It also includes comprehensive unit tests for these new behaviors. The review feedback recommends caching the computed result of prettyPrinted() to prevent redundant, expensive operations on the UI thread, ensuring better performance and consistency.
srawlins
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9521
this PR fixes issue #9521 where logs with ANSI colors were not shown properly in the Logging screen. If a log had only a background color, the text became black, so with a black background it was fully invisible in dark theme. Colored text was also bigger than the normal text, and the Details panel showed the raw escape codes like
[45mand[0m.How I fixed it:
textSpansFromAnsiwas creating a newTextStylefor colored spans and dropping the default style, so the color became null (black) and the font size fell back to default. Now it usesdefaultStyle.copyWith(...), so colored spans keep the theme color and font size and only change what the ANSI code sets.For the Details panel, I added a
stripAnsi()helper and used it inLogData.prettyPrinted(), so the details text, search and copy all get clean text. Fordart:developerlogs the details are JSON, and JSON encodes the escape char as\u001b, so I handle that too.before --

after --


Pre-launch Checklist
General checklist
///).Issues checklist
contributions-welcomeorgood-first-issuelabel.contributions-welcomeorgood-first-issuelabel. I understand this means my PR might take longer to be reviewed.Tests checklist
AI-tooling checklist
Feature-change checklist
release-notes-not-requiredlabel or left a comment requesting the label be added.packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.If you need help, consider asking for help on Discord.