Repository navigation
feat(sessions): let a session message steer the running turn - #116
Merged
Merged
Conversation
SessionMessageRequest gains Steering. When the session has a turn in flight, the server takes a steering message into that turn at its next step instead of queueing it for a turn of its own; the running turn then answers it, so its answer is read from the session's event stream rather than from the message's own invocation. The field is omitted when false, so existing requests are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SessionMessageRequestgainsSteering(json:"steering,omitempty").When the session has a turn in flight, the server takes a steering message into that turn at its next step instead of queueing it for a turn of its own. The running turn then answers it, so callers read the answer from the session's event stream rather than from the message's own invocation. The field is omitted when false, so existing requests are byte-identical.
Tests
TestSessionsWriteMessageSendsSteering:steering:truereaches the wire.TestSessionsWriteMessageSendsRequestAndDecodesAck: a false value is omitted.make check(fmt, golangci-lint v2.13.0: 0 issues,go test -race ./..., build) passes.