Repository navigation
fix(gen): RUM dashboards and nullable unions; sync OpenAPI spec - #113
Merged
Merged
Conversation
- RUM/Dashboards and Monitors/Dashboards both produced a Dashboards service, which does not compile. RUM becomes RumDashboards, and a name collision now fails generation. - oneOf/anyOf of a schema and null emitted any. It now generates the same pointer as a nullable $ref. - A field typed differently across oneOf arms took the last arm's type, which fails to decode the others. It now generates any.
Adds client.RumDashboards, alert email, enrichment and pipeline previews. Breaking: request types with inline duplicates now use the shared models (FilterGroup, TimeFilter, EscalateLayer, Group, Flapping), and nullable fields such as ScheduleItem.CurOncall are pointers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #103, which does not compile.
Generator
RUM/DashboardsandMonitors/Dashboardsboth generatedDashboards. RUM is nowRumDashboards;client.Dashboardsstays Monitors. A collision now fails generation.oneOf/anyOfof a schema andnullgeneratedany; it now generates a pointer, the same as a nullable$ref.oneOfarms now generatesany, so every arm decodes.Spec
Synced from flashduty-docs main. Adds
RumDashboardsand the alert email, enrichment and pipeline previews.Breaking
Release as a minor bump.
FilterGroup,TimeFilter,OnceTimeFilter,EscalateLayer,Group,Flapping.ScheduleItem.CurOncall/NextOncall/Notify,ScheduleByPersonResponse.Current/Next,GetRemoteConfigResponse.Config,ScheduleCalculatedSchedule.Group.EscalateRuleItem.ChannelNameandPreviewTemplateResponse.FixedFields.