Repository navigation
docs(doc-review): daily review 2026-11-10 — trading calendars & half trading days, team dispatch targets, service-calendar limit - #1178
Open
flashduty[bot] wants to merge 1 commit into
Conversation
![flashduty[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…rading days, team dispatch, calendar limit - service calendars: limit 5 -> 20 and drop the 'contact support' remedy - service calendars: document half trading days (HK 12:00, US 13:00, A-shares none) - escalation rules / silence rules: trading calendar as a direct time condition, 交易日/休市日 labels, pre-filled exchange session, half-day post-close counts as rest - incidents: teams are a direct-assign / responder target (snapshot expansion, max 20 teams, max 100 people after expansion) - changelog: entry for trading calendars and the raised service-calendar limit
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc Review — 2026-11-10
Mode: diff (since 2026-11-09T09:20:05Z, ≈23h → 2026-11-10T08:11Z)
Findings: 9 total — 0 high, 7 medium, 2 low (7 applied in this PR, 1 cross-repo follow-up, 1 held for a human)
Changes
target_repo: flashduty-website, see Cross-repo follow-upsReview checklist
maxCalInOneAccount,MAX_PERSONAL_CALENDARS), 20 teams / 100 people (AssignedTo.TeamIDs binding lte=20,scopeAssignTargets), HK 12:00 + US 13:00 half-day closes and the 09:30-15:00 / 09:30-16:00 sessions (TimeRange.tsx,exchangecal/hk.go)pages/ServiceCalendar/locales/*,pages/Channel/locales/*), not inventedservice-calendar.mdx) while the two policy pages only link to itCross-repo follow-ups (flashduty-website)
content/changelog/. Feature: exchange trading calendars (A-share / HK / US) usable as a service-calendar link or as an escalation/silence time condition, plus half trading days and the service-calendar limit 5 → 20. Action: add a dated.mdx+.zh.mdxpair. The newest existing pair is2026-11-08-341213.*, so nothing covers this release (calendars seeded 2026-11-05, console work landed 2026-11-09/10).Mapping warnings
fc-pgy: the service-calendar backend (cmd/server/controller/calendar,logic/calendar,structs/calendar.go,deploy/holiday.sql) is not inmapping.yamlat all — this whole PR's evidence lives outside the mapping. Suggest adding it under theon-callmodule.fc-event:cmd/server/controller/incidentandcmd/engine/controller/alertare unmapped although they changed this window. This round scanned them manually (the team-assignment changes are inlogic/incident/assign.go, which is mapped).flashduty-docs:derivative_surfaces.comparison_pagepoints atzh|en/on-call/quickstart/comparison.mdx, which does not exist; the real files arezh|en/on-call/comparison/vs-pagerduty.mdxandvs-opsgenie.mdx.fc-foundation-app: submodulesrc/Packages/ai-kitdeclaresgit@github.com:flashcatcloud/ai-kit.git, which has no remote (git clonefails, recorded inrepos_skipped).Skipped
zh|en/on-call/comparison/vs-pagerduty.mdxhas no row for calendar-scoped dispatch (service calendar / trading calendar as an escalation or silence condition). Only the Flashduty side can be drafted from code; PagerDuty/Opsgenie cells need verified public sources, so this is left to a human rather than shipped with an invented or blank competitor cell.fc-rumcrash beacon +t_crash_ledger(/api/v2/rum/crash,crashBeaconEnabled,crashBeaconTimeoutMs500–2000 ms): the knobs are backend/remote-config only —fc-saas-rumhas no remote-config UI change this window, so there is nothing a console reader can set. Frontend-first rule applied.monit-webapiClaimAlertRuleEventOutbox: pure MySQL claim/locking change, no user-visible behavior.monit-edgeCollapseDuplicateTableDimensions: AnyData/NoData now keep the first of several equal-dimension table rows; docs never described duplicate-dimension freezing, so there is no stale claim to fix.fc-statuspagemodel/unique_constraint.go,types/id.go,logic/migration: internal ID-collision retry.fc-safarimid-turn absorption, LLM error classification, steering removal: internal agent runtime; the console never exposes these names.ai-sre-web/meow-uipaged transcript ("加载更早的消息"): self-explanatory UI, no doc claim.fc-foundation-applocale additions (无人值班/无成员/暂无分派策略/停用中) andfc-saas-rumrrweb replay machine: labels and internals, no feature change.active_devices_enabled,/oncall/license/list), docs(doc-review): daily review 2026-11-04 — RUM session AI summary, AI SRE session credits, per-rule new-alert limit, engine install addresses #1165, docs(api-reference): daily api-review 2026-11-04 — timeline byline, escalate layers minItems, RUM session summary flag, session credits fields #1164, docs(rum): HarmonyOS crash thread dumps and memory at the fault #1153 (HarmonyOS crash threads). docs: 补充资源响应上下文场景并精简 Web SDK 高级配置 #1168 is merged and contributes nothing to this window; its RUM/Web SDK material was not touched.deploy.holidaySource(center/local) in fc-pgyconfig/config.go+etc/deploy.yml, and fc-rumcrash_beacon_ip_limit/crash_beacon_app_limit. The docs site has no self-hosted/config-file chapter (grep -rn holidaySource zh/ en/→ 0 hits), so these keys have nowhere to land today.Validation
mint broken-links→success no broken links found(exit 0), run with the branch working tree after all edits.jq empty docs.json→ clean. No pages were created, renamed or moved, so nodocs.jsonnavigation or redirect changes were needed.comm -12) → empty intersection; all 12 changed files were read against source.