Skip to content

refactor: remove unused uiRouteAuth and settings page - #1906

Closed
jescalada wants to merge 7 commits into
mainfrom
ui-auth-cleanup
Closed

jescalada wants to merge 7 commits into
mainfrom
ui-auth-cleanup

Conversation

@jescalada

Copy link
Copy Markdown
Contributor

Description

Removes everything related to uiRouteAuth which I added a long time ago in #1091 (when I didn't quite understand the project and our requirements).

Related Issue

Resolves #1296

Checklist

General

Documentation

  • Documentation has been added/updated for any new features

Configuration

  • If configuration schema (config.schema.json) was modified:
    • TypeScript types regenerated (npm run generate-config-types)
    • Schema reference docs regenerated (npm run gen-schema-doc)

Tests

  • Tests have been added/updated for new functionality
  • Unit tests pass (npm test)
  • Linting and formatting pass (npm run lint and npm run format:check)
  • Type checks pass (npm run check-types)

@jescalada
jescalada requested a review from a team as a code owner November 18, 2026 02:00
@netlify

netlify Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit 1aa4807
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6afd14e3808366e53402de1a
😎 Deploy Preview https://deploy-preview-1906.git-proxy.preview.finos.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov

codecov Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.86%. Comparing base (9b2501d) to head (1aa4807).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1906      +/-   ##
==========================================
- Coverage   88.87%   88.86%   -0.01%     
==========================================
  Files         127      127              
  Lines        7092     7086       -6     
  Branches     1318     1318              
==========================================
- Hits         6303     6297       -6     
  Misses        493      493              
  Partials      296      296              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada

Copy link
Copy Markdown
Contributor Author

Closing this for now - still need to figure out the original behaviour while keeping the RouteGuard (and not break the tests along the way)...

@jescalada jescalada closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make uiRouteAuth more flexible

1 participant