Repository navigation
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1893 +/- ##
==========================================
+ Coverage 88.87% 88.88% +0.01%
==========================================
Files 127 127
Lines 7092 7092
Branches 1318 1318
==========================================
+ Hits 6303 6304 +1
Misses 493 493
+ Partials 296 295 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dcoric
left a comment
There was a problem hiding this comment.
One ordering issue: in tagPushChainElements, checkIfWaitingAuth still runs before pullRemote, writePack and checkHiddenCommits. Once a tag push is approved, the re-push finds the approval, sets allowPush and leaves the chain before the new check. That re-push is the one forwarded upstream, so its pack is never checked for hidden commits.
The branch chain runs checkHiddenCommits before checkIfWaitingAuth. Could we move checkIfWaitingAuth after checkHiddenCommits here too, and extend the chain-order test to cover it? Everything else looks good.
|
@dcoric You're right, I didn't notice that 👍🏼 Should be good for a final look! |
|
CI is failing from a Docker image fetch failure... Should be good to merge otherwise |
Description
Adds
checkHiddenCommitsto tag push chain, and regression tests. Tag pushes were added in 2.1 but were missing this processor. Although this appears to be a regression from GHSA-v98g-8rqx-g93g, I'm not aware of any other orgs actively using tag pushes (and even then it's hard to exploit despite the risk score).Checklist
General
Documentation
Tests
npm test)npm run lintandnpm run format:check)npm run check-types)