Skip to content

ci: publish git-proxy-cli to npm - #1654

Open
jescalada wants to merge 13 commits into
mainfrom
fix-cli-publishing
Open

jescalada wants to merge 13 commits into
mainfrom
fix-cli-publishing

Conversation

@jescalada

@jescalada jescalada commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds workflow jobs to automatically publish @finos/git-proxy-cli to NPM. Ideally, we should merge #1520 and #1627 before this one to make sure future releases (2.1.0, etc.) work correctly for both the parent package and CLI.

Requirements

Related Issue

Resolves #1653

Checklist

General

Documentation

  • Documentation has been added/updated for any new features

Configuration

Tests

  • Tests have been added/updated for new functionality
  • Unit tests pass (npm test)
  • Linting and formatting pass (npm run lint and npm run format:check)
  • Type checks pass (npm run check-types)

@jescalada
jescalada requested a review from a team as a code owner July 22, 2026 02:54
@netlify

netlify Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit 2db9d35
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6afbf8248b2c06eee48fe536
😎 Deploy Preview https://deploy-preview-1654.git-proxy.preview.finos.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/axios ^1.18.1 UnknownUnknown
npm/yargs ^18.0.0 UnknownUnknown

Scanned Files

  • packages/git-proxy-cli/package.json

@jescalada jescalada mentioned this pull request Jul 22, 2026
7 tasks done
@codecov

codecov Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.87%. Comparing base (9b2501d) to head (2db9d35).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1654   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files         127      127           
  Lines        7092     7092           
  Branches     1318     1318           
=======================================
  Hits         6303     6303           
  Misses        493      493           
  Partials      296      296           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoric dcoric left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CLI builds and runs locally, but two release-flow issues need fixing before merging: preserve the existing release-tag and dry-run handling for CLI publishing, and update the patch bumper so the CLI dependency pin passes the new lockstep guard. Details are inline.

This also needs a refresh against main to resolve the workflow and manifest conflicts. Could we add checks covering a maintenance release and a patch bump followed by the version guard?

Comment thread .github/workflows/npm.yml Resolved
Comment thread .github/workflows/npm.yml Resolved
@jescalada
jescalada requested a review from dcoric November 17, 2026 07:57
@jescalada

Copy link
Copy Markdown
Contributor Author

@dcoric Did some pretty large-scale refactors here while incorporating the latest workflow changes from main. Hope you don't mind taking another look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish @finos/git-proxy-cli to npm, check quickstart guide accuracy

2 participants