Repository navigation
froxels: use a camera-centered metric world box - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transparency froxel fill and both consumers used a fixed world box in Quake units (-4096,-2048,-4096, size 8192x4096x8192), while the renderer scene is metric. The fill probes were kilometres away and the sampled cells were empty, so the blend weight had nothing to scale.
The box is now a camera-centered 32.512 m cube (the report's 1280 u), shared by
CmBuildTransparencyFroxels.comp.hlsl,GlassPaint.hlsliandRsParticle.frag.hlslthroughTransparencyFroxels.hlsli.Runtime
ad_swampy, blend 0/0.5/1:[64.85, 53.21, 37.90],[66.75, 55.00, 39.61],[65.78, 54.03, 38.67]. Per-pixel animation noise is still 5.3 and the 0.5 point is not monotonic, so this is not yet a clean visual A/B (green coverage 0.044% at this view); the unit fix is required regardless because it puts the fill probes back in the scene. All three shaders compile with dxc.