Skip to content

idtech8: validate ReSTIR GI history and taps with the receiver normal - #88

Merged
f1ames0ff merged 2 commits into
masterfrom
feat/idtech8-restir-gi-receiver-normal
Nov 11, 2026
Merged

f1ames0ff merged 2 commits into
masterfrom
feat/idtech8-restir-gi-receiver-normal

Conversation

@f1ames0ff

Copy link
Copy Markdown
Owner

What

Validates the ReSTIR GI history and taps against the receiver pixel's normal:

  • pad stores the receiver normal (8+8-bit octahedral) and the current frame, refreshed every
    frame before the store (q2GiUpdateReceiver).
  • The main history and all four spatial taps use q2GiHistoryValid; the selected sample's origin
    normal is no longer involved.
  • q2GiTouch remains for age-only refreshes in the CPU twin.

Verification

  • CPU twin: 44 checks, 0 failures.
  • Runtime e1m1, master ci-windows-43051875171 hot-swap: GI on [69.4, 40.3, 32.1] vs off
    [69.4, 40.3, 32.0].
  • The on/off equality is unbiased convergence, not disabled history: acceptance counters over
    30 frames show main history 12.24M accepted / 59k rejected and taps about 1.6M accepted /
    46k rejected
    per frame. The earlier main-only validation was over-bright ([72.1] vs
    [63.2]) because unvalidated taps reused wrong-normal radiance.

Built on the merged GI validation (#86, #81).

@f1ames0ff
f1ames0ff merged commit 57bc56d into master Nov 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant