Repository navigation
idtech8: validate ReSTIR GI history and taps with the receiver normal - #88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Validates the ReSTIR GI history and taps against the receiver pixel's normal:
padstores the receiver normal (8+8-bit octahedral) and the current frame, refreshed everyframe before the store (
q2GiUpdateReceiver).q2GiHistoryValid; the selected sample's originnormal is no longer involved.
q2GiTouchremains for age-only refreshes in the CPU twin.Verification
ci-windows-43051875171hot-swap: GI on[69.4, 40.3, 32.1]vs off[69.4, 40.3, 32.0].30 frames show main history 12.24M accepted / 59k rejected and taps about 1.6M accepted /
46k rejected per frame. The earlier main-only validation was over-bright (
[72.1]vs[63.2]) because unvalidated taps reused wrong-normal radiance.Built on the merged GI validation (#86, #81).