Repository navigation
overlays.ifstate: add dhcpcd_latest (upstream 10.5.2) for netif - #43
Merged
Merged
Conversation
The owner chose the upstream release over the two-commit patch. A fleet-wide swap of pkgs.dhcpcd is not possible yet: from 10.5.1 dhcpcd calls chown on its control socket, and the system-call filter of the NixOS dhcpcd.service kills it at start (NixOS/nixpkgs#562813 is open). So 10.5.2 comes as its own attribute, dhcpcd_latest, for clanServices netif, which starts dhcpcd from an IfState hook. pkgs.dhcpcd keeps 10.3.2 with the two upstream commits, unchanged. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
overlays/ifstate.nix: new attributedhcpcd_latest, the unpatched upstream dhcpcd 10.5.2 on the nixpkgs build recipe. Version guard: it becomesprev.dhcpcdonce nixpkgs ships 10.5.2 or newer.patchesis emptied with the new source.pkgs.dhcpcdis unchanged (10.3.2 with the two upstream lost-lease commits; same store path as before).flake-parts/packages.nix: exportsdhcpcd_latest.README.md: the two attributes and why.Why
The owner chose the upstream release over our patch for clanServices netif. 10.5.2 has the lost-lease fix and four CVE fixes (CVE-2026-56113, -56114, -56116, -56117).
Swapping
pkgs.dhcpcditself was tested first and would have broken DHCP on every machine withnetworking.useDHCP: from 10.5.1 dhcpcd callschownon its control socket, the NixOSdhcpcd.servicesystem-call filter kills it (dhcpcd manager hungup, restart loop, no lease). NixOS/nixpkgs#562813 adds@chownto the unit and is still open. netif starts dhcpcd from an IfState hook, so it can take 10.5.2 by name now.Checks
fmt,check: pass.nix build .#dhcpcd .#dhcpcd_latest: builds;dhcpcdstore path unchanged.dhcpcd_latest:eloop_event_add. Same withipv4only.dhcpcd.service+ 10.5.2: fails to start.SystemCallFilter = ["@chown"]+ 10.5.2: passes (boot, five down/up, carrier loss, renewal, unit restart, reboot).pkgs.dhcpcd(control): passes.For the reviewer
dhcpcd_latestyet. clanServices switches netif to it in its next phase.🤖 Generated with Claude Code