Repository navigation
overlays.ifstate: dhcpcd with the upstream fix for lost leases after a carrier change - #42
Merged
Merged
Conversation
dhcpcd 10.3.x closes a DHCPv6 address socket before deleting it from its event loop. After a carrier change the next socket that reuses the descriptor number is never read, and DHCPv4 or DHCPv6 does not recover (upstream issue 596). Carry the two upstream commits of PR 611 until nixpkgs ships 10.5. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
overlays/ifstate.nix:dhcpcdbuilt with two upstream commits, guarded byversionOlder old.version "10.5.0"so they drop out when nixpkgs ships 10.5 or newer.overlays/patches/dhcpcd/: the two commits, unmodified, from NetworkConfiguration/dhcpcd PR 611 (3375f52"eloop: always remove event from list on delete",cf232b9"DHCP6: Delete the eloop event before closing an ia listener socket").flake-parts/packages.nix:packages.<system>.dhcpcd, so the patched build is buildable directly.README.md:overlays.ifstateis the host-networking set; patches nixpkgs lacks live here.Why
dhcpcd 10.3.2 closes a DHCPv6 address socket before it removes it from its event loop. The loop keeps a stale entry, the next socket that reuses the descriptor number fails with
eloop_event_add: No such file or directory, and nobody reads it. After any carrier change DHCPv4 or DHCPv6 then does not come back. Upstream issue 596 reports the same lines; 10.5.0 has the fix.Found by the clanServices netif probes (specs/netif.md N16, §8.3). Run alone on euc-hel-0:
ip link set down/upcycles: DHCPv4 back, DHCPv6 backChecks
fmt: 0 files changed.check(nix run .#flake-check): all checks passed.nix build .#dhcpcd: both patches apply; the same store path ran in the probes above.Reviewer notes
overlays.ifstateoroverlays.defaultgets this dhcpcd on its next org-pkgs bump and deploy, including machines that use plainnetworking.dhcpcd. The change is the two upstream bug-fix commits only.org-pkgsin its own PR.🤖 Generated with Claude Code