Repository navigation
Render Cilium without chart-generated certificates - #40
Merged
Merged
Conversation
The Cilium chart generated a CA and the clustermesh-apiserver and Hubble server keys on every render. The committed manifest therefore held six TLS Secrets with private keys, and no two renders matched, so the repo carried no freshness check. Turn off clustermesh-apiserver TLS auto generation and turn Hubble off (D1: Cilium is networking only; Hubble never had certs in clanServices clusters). The render is now deterministic, the manifest holds no Secret and no key, and checks.manifest-cilium-freshness is back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pkgs/cilium/values.nix:clustermesh.apiserver.tls.auto.enabled = false;hubble.enabled = false.manifests/cilium/1.20.3.yaml: regenerated withnix run .#update-manifests. These objects are removed:cilium-ca, the fourclustermesh-apiserver-*-cert,hubble-server-certs;hubble-peerService;cilium-config(enable-hubble: "false").flake-parts/components/cilium.nix: brings backchecks.manifest-cilium-freshness, using the existinglib.manifestFreshnessCheck.README.md: says the manifest has no certs and has a freshness check.Why
nix build .#manifest-cilium --rebuildfailed with "may not be deterministic", so no freshness check was possible.hubble-server-certs, so Hubble TLS was never usable in those clusters.Checks
nix build .#manifest-cilium --rebuild: passes (identical output). Before this change it failed.kind: Secretand 0 PEM or base64 PEM blocks.fmt: 0 files changed.check: all checks passed (x86_64-linux), includingmanifest-cilium-freshnessandcilium-airgap-completeness.Merge order and follow-up
org-pkgs(nix flake update org-pkgs, thensync-locks) and rerunsvm-test --all --remote --rebuild. The bundle there has to supply the four clustermesh cert Secrets, which it already does inlib/kube-cluster/bootstrap.nix.🤖 Generated with Claude Code