Repository navigation
Runner self-test, --resume, grep -q lint and the eval-warning gate - #33
Merged
Merged
Conversation
From the clanServices modernization retro: - checks.vm-test-runner (vmTests.runnerSelfTest, on in pkgs): the runner, now built by mkRunner, runs for two stub tests against a fake nix: PASS, PASS(!), FAIL alone/also alone, preparation retry, CACHED, --summary, --resume, --rebuild. The two runner bugs of pkgs#31/#32 reached real VM runs first; reintroducing the wait -n one fails it. - vm-test --all --resume continues an interrupted run: result.txt now records the test derivation, and a test that passed for the same one is skipped. - The per-test check and vm-tests-resources fail on `| grep -q` in a test script (SIGPIPE under pipefail), a rule that was prose only. - apps.flake-check (flakeModules.default), used by the devenv `check` script and org-ci: nix flake check, then evaluation warnings listed; those matching evalWarnings.deny (ignored, removed or insecure config) fail. Ordinary warnings pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andrewthomaslee
enabled auto-merge (squash)
November 13, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
checks.vm-test-runnerpasses 16/16 cases.wait -nbug fixed in pkgs#31 makes it fail 2 cases.hello | grep -q …restored in smoke,vm-test --checkprintedsmoke: | grep -q in a pipe …and1 of 1 FAILED the check. modules and clanServices have no such pipe.nix flake checkwith 2stdenv.is*deprecation warnings that nothing reports.nix run .#flake-check(home, local override of org-pkgs) lists both and passes. With a temporaryevalWarnings.denymatching one of them, it fails withFAILED: dangerous evaluation warnings(exit 1).vm-test --all --remote --rebuild→PASS smoke 26s; result.txt readspassed 26 /nix/store/…-vm-test-run-smoke.drv.vm-test --all --remote --rebuild --resume→PASS smoke 26s (earlier run, --resume), nothing booted.nix run .#flake-check(pkgs): all checks passed.Merge Danger
Door: two-way
Blast Radius: org CI
Every repo's CI switches to
nix run .#flake-checkonce it bumps org-pkgs. Before that bump, the job falls back to plainnix flake check. A repo that has a dangerous warning today would go red on its bump; none of the core repos have one. Merge order: this PR, then skills, clanServices, modules, home.🤖 Generated with Claude Code