Repository navigation
Check the theme against the WordPress Coding Standards on every PR - #275
Merged
Merged
Conversation
The PHPCS, ESLint, Stylelint and Prettier setups were already here, but nothing ran them, so main had drifted to hundreds of violations. A Lint workflow now runs all four on each pull request, and `npm run lint` runs the same set locally. PHPCS gains PHPCompatibilityWP pinned to the theme's PHP 7.4 floor, and checks the `extendable` text domain and function prefix. Pattern headers skip the file-docblock sniffs: they are registration metadata. Stylelint stops flagging rule order (descending specificity, duplicate selectors): reordering theme CSS to satisfy them changes which rule wins. The generated stylesheets are skipped, since a fix made here is overwritten the next time they are generated.
Most of the diff is the fixers' whitespace. The changes a reviewer should look at: - The navigation script now carries the theme version, so a release busts its browser cache like every other theme asset. - The WooCommerce template filter drops its unused query argument. - The animation config reads through wp_json_file_decode(). - "Saving..." becomes "Saving…", a new string for translators. - product-search-results.html takes the Prettier layout the other templates already use; the site editor opens it with no invalid blocks. Checked on WordPress 7.1, PHP 7.4, with WooCommerce: the front end, the animations, and the post and site editors load with no errors.
amjadr360
marked this pull request as ready for review
November 16, 2026 01:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The theme already had the WordPress Coding Standards tools set up (PHPCS with WPCS, ESLint, Stylelint, Prettier), but nothing ever ran them, so main had built up about 950 violations. This PR fixes all of them and adds a Lint check that runs on every pull request, so new ones can't slip in.
npm run lintruns the same checks locally.extendabletext domain and the function prefix.npm run lintrun before their checks go green.Tested on WordPress 7.1 and PHP 7.4 with WooCommerce: the front end, animations, post editor and site editor all load with no errors, and the reformatted product search template opens in the site editor with no invalid blocks.