Repository navigation
Conversation
An overlay header pulls the first full-screen hero up by the header's measured height, so the photo runs behind it, but nothing pushed the hero's content back down. On a short screen, or under a tall header, the hero's centred text started behind the header: about 20px under a two-row header at 1280x720 on WordPress 7.1.2. The hero's cover now adds the header's height to its top padding, on top of the section spacing, only while the overlay applies. A hero under a normal header, or one that fits its content and so is never overlaid, keeps its padding as written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the header sits over a full-screen hero, the hero's text could start behind the header on a short screen or under a two-row header, about 20px hidden at 1280×720. This pushes the hero's text down by the header's height while the header overlays it.
Still to do
spacing-70), so it overrides whatever padding the hero pattern chose. Of the 16 full-screen hero patterns, 8 use that spacing, but 6 usespacing-60(they gain about 16px) and 2 use no top padding (they gain about 112px). The better fix adds the header's height above the hero's content and leaves the pattern's own padding alone. Needs doing before this merges, or soon after.