Repository navigation
Conversation
Produced by running:
- `rm -rf internal/testify`
- `rm -rf internal/difflib`
- `find -iname "*.go" -exec sed -i "s,github.com/expr-lang/expr/internal/testify,github.com/stretchr/testify," \{\} \;`
then deleting the two packages from the coverage config in
`.github/scripts/coverage.mjs`.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I noticed that a couple of years ago you vendored
difflibandtestifybecausedifflibwas unmaintained and it was causing some security scanner to warn. I just noticed thattestifyalso resolved this by vendoringdifflib, so you it should be possible to drop your copy and just use their transitivedifflibinstead. I did also notice that you currently have zero dependencies, so maybe you'd rather keep things as they are, anyway. In case you would like to drop the vendoring, though, here's a mechanically produced PR. All tests run by.github/workflows/test.ymlpass.Produced by running:
rm -rf internal/testifyrm -rf internal/difflibfind -iname "*.go" -exec sed -i "s,github.com/expr-lang/expr/internal/testify,github.com/stretchr/testify," \{\} \;then deleting the two packages from the coverage config in
.github/scripts/coverage.mjs.