Repository navigation
refactor(audit): take the keep set, the bundlers and the next PHP image from where ncmake holds them - #424
Merged
ernolf merged 1 commit intoNov 6, 2026
Conversation
…ge from where ncmake holds them Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
ernolf
added
bug
github-actions
Bot
deleted the
ernolf/refactor/single-source-keep-bundlers-php-image
branch
November 6, 2026 02:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #420
Four analysers kept a copy of a value ncmake already holds elsewhere. They now take it from there.
The bundlers: build-audit, built-assets and consistency-audit each had their own list of bundler packages. bundler-config.mjs now names, per bundler, the configs it picks up, the package that writes the output, the packages an app declares for it and the packages it runs. The three analysers read from that.
The keep set: consistency-audit fell back on a copy of the core's keep_dirs and keep_files when make handed in no set, without keep_extra. The copy is gone. Without the set make hands in, the check of the directories the app reads at run time is left out, and an info finding says so.
The PHP image ahead of master: php-compat wrote the image repository into its own source. The core now names it once as php_image_repo, make writes the image it ran into the range file, and the report takes it from there.
In the JSON of consistency-audit, keepFrom is gone and the bundlers come in the order of bundler-config.mjs. The JSON of php-compat carries range.next_image.
Tested with php-compat, consistency-audit, build-audit, bundle-report and build-verify on twofactor_oath, against main.