Repository navigation
Fix GX texture minification decoding and signed LOD bias encoding - #293
Merged
encounter merged 2 commits intoOct 20, 2026
Merged
Conversation
AttilaTheFun
marked this pull request as ready for review
October 17, 2026 21:48
Owner
|
Appears to be correct, thanks! |
magcius
pushed a commit
to TwilitRealm/aurora
that referenced
this pull request
Oct 27, 2026
…counter#293) * Fix GX texture minification decoding and signed LOD bias encoding * Remove explanatory comments from texture fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small texture fixes from our Melee port:
GX_LIN_MIP_NEARandGX_NEAR_MIP_LINwere swapped when decoding the hardware filter bits.u8; the direct float-to-byte cast is undefined.Added round-trip tests for both. They reproduce the issues on main, and all 232
gx_fifo_testspass with the fixes on macOS arm64, with float-cast-overflow UBSan enabled.