Skip to content

Create a group widget for metrics of the same device - #577

Open
stsdc wants to merge 12 commits into
mainfrom
stsdc/better-indicator
Open

stsdc wants to merge 12 commits into
mainfrom
stsdc/better-indicator

Conversation

@stsdc

@stsdc stsdc commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Grouping allows to save some space by using a single icon for all metrics of a device.
image
NEW:
image
OLD:
image

@stsdc
stsdc marked this pull request as ready for review September 26, 2026 15:06
@stsdc
stsdc requested a review from a team September 26, 2026 15:10
@danirabbit

Copy link
Copy Markdown
Member

I'm a fan. Seems more easily parsable at a glance too

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint is failing :)

Comment thread src/Indicator/Widgets/IndicatorGroupWidget.vala Outdated
Comment thread src/Indicator/Widgets/IndicatorGroupWidget.vala Outdated
Comment thread src/Indicator/Widgets/IndicatorWidgetBandwidth.vala Outdated
@stsdc
stsdc force-pushed the stsdc/better-indicator branch 2 times, most recently from afadd31 to 2c3889e Compare September 28, 2026 20:52
@stsdc
stsdc force-pushed the stsdc/better-indicator branch from 2c3889e to 413ac9a Compare September 28, 2026 20:54
@flodavid

Copy link
Copy Markdown

No VRAM icon feels a bit weird to me

@stsdc
stsdc requested a review from danirabbit October 10, 2026 16:42
stsdc and others added 4 commits October 13, 2026 11:35
* DisplayWidget: add tooltips to groups

* More granular tooltips

---------

Co-authored-by: Stanisław <6031763+stsdc@users.noreply.github.com>
* Use Granite.Box and css spacing

* groups are themselves in revealers, css again

* Remove unnecessary formats

* Fix warning and error classes

* WidgetPercentage: Set width chars

---------

Co-authored-by: Stanisław <6031763+stsdc@users.noreply.github.com>
@stsdc

stsdc commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Spacing has been fixed in #582
image

@stsdc
stsdc dismissed danirabbit’s stale review October 15, 2026 11:32

Lint is fixed. Need an approval or re-review.
"Re-request review" button does not work for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants