Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions tests/test_graphql_value_mapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import json
from pathlib import Path

import pytest

from pyhilo.device.graphql_value_mapper import GraphqlValueMapper

PAYLOADS = Path(__file__).parent.parent / "doc" / "graphql"
Expand All @@ -21,3 +23,33 @@ def test_smart_meter_maps_zigbee_channel() -> None:

channel = [a["value"] for a in attributes if a["attribute"] == "ZigbeeChannel"]
assert channel == [24]


@pytest.mark.parametrize(
("ambient_humidity", "expected"),
[
pytest.param(45.5, [45.5], id="reading"),
pytest.param(0, [], id="no-sensor-zero"),
pytest.param(None, [], id="null"),
],
)
def test_thermostat_humidity_skips_missing_sensor(
ambient_humidity: float | None, expected: list[float]
) -> None:
"""Models without a humidity sensor report 0, which must not surface as 0%."""
device = _device("onAnyDeviceUpdated-tstat.json")
device["ambientHumidity"] = ambient_humidity

attributes = GraphqlValueMapper().map_device_subscription_values(device)

assert [a["value"] for a in attributes if a["attribute"] == "Humidity"] == expected


def test_thermostat_humidity_absent_field() -> None:
"""Payloads that omit ambientHumidity produce no Humidity attribute."""
device = _device("onAnyDeviceUpdated-tstat.json")
del device["ambientHumidity"]

attributes = GraphqlValueMapper().map_device_subscription_values(device)

assert not [a for a in attributes if a["attribute"] == "Humidity"]
Loading