Repository navigation
Settings: forwarders as a table with a Test column - #513
Merged
Merged
Conversation
The forwarder list ran each forwarder's numbers and its test result together in dot-separated lines, three colors to a row, which read as dense and unstructured. It is now the console's data table: Forwarder, Status, Answered, Median, 95th pct, Failed, and Test columns, with numbers right-aligned. Test Forwarders fills in the Test column, kept apart from Status, which is about live traffic. Phones get the stacked rows the other admin tables use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #512. In the row layout, each forwarder's numbers and its test result ran together as dot-separated lines, three colors to a row, so it read as dense and unstructured. A traffic status of "Not used yet" sitting next to "Test failed" also looked like a contradiction.
What changed
DataTable, the same component as the API tokens table in Settings, with these columns:admin-mobile-listrows that other admin tables use: the address and badge, one line of numbers, and the test result.Tests
web: the cells (right-aligned counts, times, the Failed tooltip), exactly three table rows after a test, and the results marked once in the table and once in the phone list.gofmt -l .is clean andgo tool mage verifypasses.Screenshots (Vandelay demo, real lookups, after Test Forwarders)
main)