Repository navigation
Updated scaffold to Eddy 5.0.0-rc3. - #30
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #30 +/- ##
=======================================
Coverage 97.36% 97.36%
=======================================
Files 11 11
Lines 76 76
=======================================
Hits 74 74
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composer.dev.jsonnow requiresdrevops/eddy-tooling~1.0.4instead of~1.0.0, andextra.eddy.versionreads5.0.0-rc3.scripts/eddy-toolingbuilds itsvendor/eddy-tooling.jsonmanifest from that constraint, so in an existing checkout the nextahoycommand, ormaketarget that runs a tooling command, sees a changed manifest and reinstalls the package first. Today that resolves to 1.0.5.A checkout built before the rc2 update still holds tooling 1.0.2 or 1.0.3 in
vendor/.scripts/eddy-toolingskips the install while the manifest is unchanged and every command the installed package declares is invendor/bin, and neither release declareseddy-login, soahoy loginandmake loginstop on a missingvendor/bin/eddy-loginuntil someone runsahoy reset. Any checkout installed before 1.0.5 also reports a port read from.envas(env)inahoy infoandmake info.Those checkouts now reinstall on their own, so
ahoy loginandmake loginwork withoutahoy reset, andahoy infoandmake infolabel a port from.envas(.env). CI anddeploy.ymlinstall the tooling fresh and resolve the newest 1.0.x on every run, which is already 1.0.5 (including theeddy-deploythat no longer force-pushes tags after a branch deployment), so this PR doesn't change them. With this module's installer answers, rc3 renders identically to rc2 apart fromcomposer.dev.json, so module code, the workflows, the wrappers, the tool configs, the docs andscripts/eddy-toolingstay as they are.Before / After
Changes
Tooling constraint
composer.dev.json:drevops/eddy-toolinggoes from~1.0.0to~1.0.4, andextra.eddy.versionfrom5.0.0-rc2to5.0.0-rc3.Merge decisions
10,11,12,ahoy,makefile, PHPCS, PHPStan, Rector, Twig CS Fixer, CSpell, PHPUnit and Renovate) differ only incomposer.dev.json, and the change applied with no conflicts.renovate.jsonkeeps its npm manager, rules and lock file maintenance. rc3 drops them only when no Node tool is selected, and CSpell counts as one.scripts/eddy-toolingalready matches rc3's copy, andpackage-lock.jsonkeeps the project's copy becausepackage.jsondoesn't change.eddy-deploy,eddy-infoand Functional test deprecation fixes ship indrevops/eddy-tooling1.0.5, and the docs rewrite covers Eddy's own documentation site.How this was tested
ahoy buildon Drupal 11.4.10 and PHP 8.4.17:scripts/eddy-toolingprintedInstalling drevops/eddy-tooling ~1.0.4.over the existing install and resolved 1.0.5.ahoy lint: PHPCS, PHPStan, Rector, Twig CS Fixer and CSpell are clean.ahoy test:OK (40 tests, 72 assertions).ahoy loginprints a one-time link that signs in asadmin. The homepage,/admin/reports/statusand/admin/modulesload with no page or console errors, and Deploy Steps shows as installed.ahoy inforeportsWebserver port: 8004 (.env).