You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Find the link after a co-editor's change in phone Edit and desktop Remove #696
#643 fixed the desktop link Edit race: Apply now finds the link again through the live element. Two paths still miss a co-editor's change. Phone Edit uses the position stored when the sheet opened. Desktop Remove acts on the editor selection.
Area:apps/webapp/src/components/TipTap/hyperlinkPopovers/linkPreviewActions.tsx (phone Edit and Remove), the desktop preview Remove button
Phone Edit and Remove run through applyEdit and removeHyperlinkAtPos with the stored nodePos. The sheet has no live <a>, so the desktop fix cannot reach it. A co-editor who types above the link moves it, and Apply then does nothing or misses.
Desktop Remove acts on the selection, which y-tiptap maps through remote changes. A selection that overlapped the link when it was clicked, or a caret that moved while the preview was open, can unlink part of the link, or another link.
Done when
Phone Edit and Remove find the link after a co-editor types above it.
Activity