Skip to content

Find the link after a co-editor's change in phone Edit and desktop Remove #696

Open

Description

@HMarzban

Summary

#643 fixed the desktop link Edit race: Apply now finds the link again through the live element. Two paths still miss a co-editor's change. Phone Edit uses the position stored when the sheet opened. Desktop Remove acts on the editor selection.

Details

  • Phone Edit and Remove run through applyEdit and removeHyperlinkAtPos with the stored nodePos. The sheet has no live <a>, so the desktop fix cannot reach it. A co-editor who types above the link moves it, and Apply then does nothing or misses.
  • Desktop Remove acts on the selection, which y-tiptap maps through remote changes. A selection that overlapped the link when it was clicked, or a caret that moved while the preview was open, can unlink part of the link, or another link.

Done when

  • Phone Edit and Remove find the link after a co-editor types above it.
  • Desktop Remove acts on the clicked link only.
  • A test pins each case.

Related

#643, #678

Activity

  1. added this to the v2.4.0 milestone on Nov 4, 2026
  2. added
    bugSomething isn't working
    EditorTiptap & Prosemirror
    on Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    EditorTiptap & ProsemirrorbugSomething isn't working

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions