[Akadib]

Changes in pyproject.toml:

• I raised the setuptools minimum from 62 to 77. The new license format below only works with version 77 or newer.

• I added license = "BSD-3-Clause" and license-files = ["LICENSE*.rst", "AUTHORS.rst"]. Setuptools now wants the license written as a standard name instead of a classifier. BSD-3-Clause matches what our LICENSE.rst says.

• I removed the License :: OSI Approved :: BSD License classifier. It’s deprecated, and it also doesn’t say which BSD license we use.

• Then I changed namespaces = false to namespaces = true. Our data folder has no init.py, so the package finder skipped it. Setuptools then warned me that the folder’s files were being shipped without the folder being listed. The data files were included before too. This change only removes the warning.

Change in MANIFEST.in:

• I removed include src/diffpy/labpdfproc/data *. The include command only matches files, not folders, so this line matched nothing that created warnings. Since graft src already includes the data folder, we can deleted it.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.17%. Comparing base (fbb42ec) to head (281ad56).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files           5        5           
  Lines         364      364           
=======================================
  Hits          361      361           
  Misses          3        3           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Akadib]

@sbillinge @stevenhua0320 ready for review for the rc-release!

[sbillinge]

Thanks @Akadib . This is great, I will merge it. These changes are needed in scikit-package. I think that there is an issue for this. Could you take that @stevenhua0320 @cadenmyers13 , looping you in on this.

[cadenmyers13]

@sbillinge @Akadib I think this repo would benefit from a review by claude. I did a large refactoring a while ago (without claude integration) so it would be good to allow it to look through to make sure i didnt include any bugs. I can handle this