Repository navigation
fix: release the large page preview when closed - #9
Merged
devnithdev merged 1 commit intoNov 1, 2026
Merged
Conversation
Owner
|
Thanks, nice clean fix, and the test is a great addition! It will go out with the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
Closing the large page view now clears
pvStage, releasing the hidden preview subtree. Reopening still renders normally, including opening the same page twice. Existing detached-holder checks prevent asynchronous drawing from inserting into the closed view.Added a plain-Node VM regression following
t13-upload-retry.js, with coverage for close, same-page reopen, different-page reopen and repeated close; included it in the PR checks and tests README.Checks run:
node "Source code/tests/t15-page-view.js": failed before the fix at "releases the large preview subtree"; all 13 checks pass after it.node "Source code/tests/t13-upload-retry.js": 11 checks pass.node --check "Source code/server/public/app.js"andgit diff --check: pass.AI assistance: Codex prepared and reviewed the change and ran these checks.
Not checked: a real PDF on an older phone, browser heap measurements, or installer/network suites. No visible layout change is intended.