Repository navigation
cc: register @llvm toolchains through a gated rules_dx hub (part of #12601) - #12800
Draft
TrapsterDK wants to merge 1 commit into
Draft
TrapsterDK wants to merge 1 commit into
TrapsterDK wants to merge 1 commit into
Conversation
…12601) //cc/private/toolchain/llvm re-declares every @llvm//toolchain toolchain with //config:toolchains_on, and MODULE.bazel registers it instead of @llvm//toolchain:all, so the gate holds for non-root consumers. patches/llvm/toolchains_gate.patch is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
TrapsterDK
added
the
needs-review
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
//cc/private/toolchain/llvm, a hub that re-declares every toolchain@llvm//toolchaindeclares (stage0 and the stage1/2/3 bootstrap toolchains, including the_msvcvariants) with//config:toolchains_onprepended totarget_settings.MODULE.bazelregisters//cc/private/toolchain/llvm:allinstead of@llvm//toolchain:all, andpatches/llvm/toolchains_gate.patchis dropped: it lived in a root-onlysingle_version_overridenaming@@//config:toolchains_on, so non-root consumers got the llvm toolchains ungated. This unblocks the llvm part of #12688.Part of #12601. Remaining: rebase #12688 on this, green
--config=nested_recordrun,nested_cache_update --from.Tested locally (linux_x86_64):
//cc/private/toolchain/llvm:allbuilds,//tools/testing:module_srcs_testpasses;--toolchain_resolution_debugselects the llvm cc toolchain with the flag on and rejects//cc/private/toolchain/llvm:linux_x86_64_to_linux_x86_64ontoolchains_onwith--@rules_dx//config:toolchains=false.//tools/testing:toolchain_gate_testfails only on@julia_toolchains//:all, which is already on main (#12747), not from this change. Nested-Bazel and consumer tests were not run locally.Evidence (linux_x86_64, macos_arm64): pending 43663611606.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX