Repository navigation
cli/cli: clippy pedantic assert_is_empty, format_push_string, wildcard_imports (part of #12395) - #12798
Merged
Conversation
…d_imports (part of #12395) Replace assert!(x.is_empty()) with messaged asserts, push_str(&format!) with write!, and glob imports with explicit lists in //cli/cli. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12395.
Cleared in //cli/cli: assert_is_empty (88), format_push_string (45), wildcard_imports (36), plus a few machine-applicable fixes.
Tests: //cli/cli:dx_cli_test, dx_man_test, agents, dev_launcher, startup_consistency, uv_sets pass. //cli/cli/tests/adopt:adopt_test has 2 failures from a
line_ending: lfgolden mismatch in the local environment, in logic this PR does not change. Nested-Bazel and consumer tests not run.Remaining in cli/cli: too_many_lines 43, similar_names 18, casts ~28, needless_pass_by_value 9, unnecessary_debug_formatting 8, elided_lifetimes_in_paths 7, unused_self 4, default_trait_access 4, format_collect 4, plus single-digit others.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX