Repository navigation
tools/testing: clear most clippy pedantic findings (part of #12395) - #12797
Open
TrapsterDK wants to merge 1 commit into
Open
TrapsterDK wants to merge 1 commit into
TrapsterDK wants to merge 1 commit into
Conversation
) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12395.
Clears the clippy pedantic, dbg_macro, rust_2018_idioms and unused_qualifications findings in //tools/testing/... from 1643 to 15: machine fixes,
# Errors/# Panicssections,Path::display()in panic messages,write!instead ofpush_str(&format!), checked casts, extension comparisons viaPath::extension.Remaining in //tools/testing (15): needless_pass_by_value 6 (lsp Session::request/notify, starlark_harness manifest/evaluated, hermetic run_dx/run), similar_names 6, too_many_lines 2 (hermetic verify_evidence, run_all), unnecessary_wraps 1 (nested test resolver).
Checked: clippy aspect with the pedantic flags on //tools/testing/...; 98 of 107 non-nested, non-consumer, non-hermetic tests pass. The 9 failures are repo content checks (language_skeleton_test, consumer root_module_test, consumer manifest golden, registration gating, macro_signatures) reporting julia/php/javascript/typescript layout problems in files this PR does not touch.
Not run: nested-Bazel, consumer, hermetic qualification tests,
tools/dx check.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX