Repository navigation
release: candidate consumer builds and tests a Swift package on BCR rules_swift (closes #12075) - #12115
release: candidate consumer builds and tests a Swift package on BCR rules_swift (closes #12075)#12115TrapsterDK wants to merge 7 commits into
Conversation
9e223a6 to
8cde182
Compare
|
Review: changes requested
Not verified: the 🤖 Generated with Claude Code |
|
Review: approve The earlier fix landed: patches/README.md now only states what Not verified: the nested run and the 🤖 Generated with Claude Code |
769983e to
d757412
Compare
|
Evidence 43219759704 (linux_x86_64) failed on
|
d757412 to
ce38903
Compare
|
Rebased onto main; evidence run 43516441662 (linux_x86_64, release_consumer_smoke_test) dispatched. Previous run 43219759704 failed on a pre-rebase tree. |
100b065 to
26e08cd
Compare
|
Harness now snapshots a checkout without .git (no parent, no alternates). Rebased on main. Evidence run 43536332072 (linux_x86_64) dispatched; nested/consumer tests not run locally. |
60c367b to
22eeb8b
Compare
|
Evidence run 43546409752 (linux_x86_64, //deploy/private/release/tests:release_consumer_smoke_test) dispatched on b8e8103. |
c25d3b3 to
0636026
Compare
|
Rebased onto main as 4 commits (merged #12656/#12571 commits and the .git-less snapshot change dropped, main has them). Last run 43546409752 failed on missing 🤖 Generated with Claude Code |
…ules_swift (closes #12075) The release consumer, which reaches rules_dx only through a local registry with no override, now writes swift/tests/consumer on Linux x86_64, asserts `mod explain rules_swift` selects the version rules_dx pins, and runs `bazel test //swift:greet_tests`. patches/README.md and the nested-tests table name the check. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwH5AS7ytCaBAYwEtU
…iles (part of #12075) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…ers (part of #12075) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…sion inputs (part of #12075) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
rules_julia is created by a rules_dx module extension since #12747, so a single_version_override on it fails as an override on a nonexistent module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
0636026 to
e447afa
Compare
|
Run 43659794958 failed in all three tests: consumers set a single_version_override on rules_julia, which main (#12747) now creates through a rules_dx extension. e447afa drops that override. Local: //tools/testing/nested:dx_nested_test, //tools/testing:module_srcs_test, //swift/tests/... pass; smoke test built, not run locally. Evidence run 43661427774 (linux_x86_64) dispatched. 🤖 Generated with Claude Code |
…ifests (part of #12075) The registry consumer failed loading //swift: swift/private/platforms was not a package in the archive. The quickstart consumers failed analysing //:dx: the .github actions glob matched nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
|
Run 43661427774: the candidate test reached the Swift stage and failed because swift/private/platforms was not in module_srcs; the quickstart tests failed on an empty .github actions glob. 203bd5d adds both to module_srcs. Local: //tools/testing:module_srcs_test passes. Evidence run 43662333255 (linux_x86_64) dispatched. 🤖 Generated with Claude Code |
…crate patches (part of #12075) The registry consumer's swift tests depend on //swift/private/tools:swift_format, and rules_dx's crate annotations patch ring and gomod-parser from @rules_dx//patches, so consumers fetching those crates need the packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
|
Run 43662333255: Swift stage failed on missing //swift/private/tools; quickstart tests failed fetching gomod-parser (its patch lives in @rules_dx//patches/gomod-parser). c7e4456 adds swift/private/tools, patches/gomod-parser and patches/ring to module_srcs. Local: //tools/testing:module_srcs_test, //swift/private/tools/... pass. Evidence run 43663605314 (linux_x86_64) dispatched. 🤖 Generated with Claude Code |
|
Run 43663605314 (3rd round, c7e4456) still fails, further along:
🤖 Generated with Claude Code |
Part of #12075 (also #11415)
a_candidate_archive_builds_tests_and_checks_a_registry_consumer(deploy/private/release/tests/candidate_consumer_test.rs) gainsassert_swift_consumer, Linux x86_64 only, run afterdx check //...and the GCC step. It writesswift/tests/consumerinto the registry-only consumer (no override), assertsbazel mod explain rules_swiftshows the version rules_dx pins, and runsbazel test //swift:greet_tests.swift/tests/BUILD.bazel:consumer_srcsfilegroup, visible to the release test package.deploy/private/release/tests/BUILD.bazel: adds it todata.patches/README.md:## rules_swift on Linuxsection names the test.docs/design/nested-tests.md: release consumer row extended.Tests
Built
//deploy/private/release/tests:release_consumer_smoke_test. Not run locally (nested consumer test); Evidence: run 43516441662 (linux_x86_64) failed in all three tests of the target before reaching the swift step, on code this PR does not touch: candidate_consumer_test panics in dx_test_scratch::git ("not a git repository") in the sandboxed harness, and quickstart_consumer_test fails on "javascript is not a package" because //:module_srcs has no javascript package (same partial module_srcs as nested: swift_linux extension check moves out of the harness consumer, bazel mod fails on its partial module_srcs (part of #11415) #12261). Rebased on main de968cb; no new evidence until those are fixed on main. Built the target locally; not run (nested consumer test).//patches/...pass.//tools/ci:prose_rules_testand//tools/ci:test_budget_testfail on files this PR does not touch (MODULE.bazel, deploy/README.md, docs/support-matrix.md, api_spec/helm/swift/private budget counts), same on main.Stacked on PR 12656 (module_srcs carries the //cli/cli:dx and dx_generated_policy closure). Also stacked on PR 12571 (its 10 commits cherry-picked: consumers pin patched rules_py, rules_flutter, rules_rust and llvm). Evidence: run 43544584889 (linux_x86_64, //deploy/private/release/tests:release_consumer_smoke_test) failed in all three tests: runfiles lacked patches/rules_rust (and patches/llvm), which the consumers copy. b8e8103 adds those patches to
data; built locally, no further evidence run in this round. Run 43543126252 failed in all three tests onkey "3.47.9" not foundin stock rules_flutter (release: release_consumer_smoke_test fails on rules_py and rules_flutter 3.47.9 resolution in consumers (linux and windows) #12005), which PR 12571 fixes. Run 43541251765 failed: the archive lacked java/private/toolchain and cli/advisory_prep, which MODULE.bazel names.Remaining:
dataentries if it lands first.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD