Repository navigation
ci: Work around Compose's external Dockerfile permission error - #1330
Open
Christof Marti (chrmarti) wants to merge 2 commits into
Open
Christof Marti (chrmarti) wants to merge 2 commits into
Christof Marti (chrmarti) wants to merge 2 commits into
Conversation
Move Compose detection and source installation into a shared composite action. Check the installed version tag for docker/compose#14325, keeping fixed versions and the known source build unchanged. Preserve Buildx security enforcement and limit each existing workflow to one setup action. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace GitHub API version checks with a scratch build. Install the pinned source fix only for the matching fs.read failure, verify it with the same probe, and clean up the temporary files and image. Preserve unexpected failures instead of treating them as the Compose bug. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved findings remain, and the reported CI validation confirms successful workflow integration.
No open issues 🎉
What changed in this PR
Adds a CI-only workaround for Compose’s external-Dockerfile permission bug without changing CLI runtime behavior or disabling filesystem checks.
Changes:
- Adds a behavioral probe that installs pinned Compose source only for the specific permission failure.
- Verifies the replacement and cleans up probe resources.
- Integrates the shared action into both affected workflows.
| File | Description |
|---|---|
.github/workflows/test-docker-v29.yml |
Runs Compose setup after Docker 29 installation. |
.github/workflows/dev-containers.yml |
Runs Compose setup after Docker configuration. |
.github/actions/setup-compose/action.yml |
Implements probing, conditional installation, verification, and cleanup. |
Review effort: Balanced
Christof Marti (chrmarti)
marked this pull request as ready for review
October 19, 2026 15:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FROM scratchand a label. No image downloads or containers are needed. If it builds successfully, keep the installed Compose.--allow=fs.readerror naming its Dockerfile. Other failures retain their exit status and fail setup explicitly.1e1c577eab08ceb5ff0fcf4d8e3cbbc08a34ef35from fix(bake): grant permissions for configured build inputs docker/compose#14325, verify the checkout, and install it as5.6.0-dev.1e1c577to preserve CLI capability detection. Rerun the same probe after installation to verify the actual behavior.Related to #1320; addresses the CI failures observed on #1329 without including that PR's dependency update. This is a CI workaround, not a runtime fix for CLI users.
Validation
npm run compileandnpm run precommitpassed.Follow-up
Runners with working Compose skip the source build automatically. Remove this workaround once all affected runners ship fixed Compose.