Repository navigation
feat(system_test): SVT discovery cleanup, PowerVault and PowerScale CSI inputs, per-cluster inputs file - #5814
Merged
Rajeshkumar-s2 merged 5 commits intoNov 16, 2026
Conversation
balajikumaran-c-s
requested review from
RvishankarOMnia,
VenkateswaraVatam,
abhishek-sa1 and
snarthan
as code owners
November 16, 2026 09:46
…SI inputs, per-cluster inputs file - Cleanup: add the discovery suite (after the orchestrator, only when discovery holds deployed state) to the SVT cleanup steps, settings, report suites and test requirements. - PowerVault: user_inputs.yml gives only ip (a list or comma separated), iscsi_initiator and volume_id; the generator holds the defaults and builds powervault_config in storage_config.yml. Without an ip there is no PowerVault (ignored, an earlier block is removed); with an ip the other two are required. - PowerScale CSI: new setup step "files" (./setup_env.sh --stage-files, last step of a run, and run by the pipeline after the credentials) copies secret.yaml and values.yaml to the paths of omnia_config.yml only when enable_powerscale_csi is true; both must exist, have content and be valid YAML. The paths may use $NAME of omnia.env and default to the orchestrator project input folder. Header-only secret.yaml and values.yaml ship next to user_inputs.yml and are seeded (never replaced) in each cluster folder of the GitLab project. - Pipeline: each cluster picks its inputs file with <CLUSTER>_SVT_USER_INPUTS (svt.user_inputs, default user_inputs.yml). - Fix: a rerun with an empty ib_addr_mode no longer fails once the key was removed. Signed-off-by: balajikumaran-c-s <balajikumaran.cs@dell.com>
balajikumaran-c-s
force-pushed
the
feat/svt-discovery-cleanup-powervault-powerscale
branch
from
November 16, 2026 10:07
b256702 to
6a8dc23
Compare
…eference examples - --create adds secret.yaml and values.yaml to each cluster folder of the GitLab project by copying src/orchestrator/examples/powerscale_reference_files/CSI_driver/ (only when missing, never replaced, not by --update-inputs); the user edits them for the array there. - The "files" step fails, naming the file and what to edit, when a staged file is still identical to its reference example: an unedited example would only fail later, at deployment. - Drop the header-only secret.yaml and values.yaml from test/system_test: the examples are the single source, so they cannot drift. Signed-off-by: balajikumaran-c-s <balajikumaran.cs@dell.com>
…d_stream tests - system_test/requirements.txt: exact versions (pytest 9.2.0, pytest-order 1.5.0, PyYAML 6.0.3, ruamel.yaml 0.19.1), the ones the other suites pin and the SVT .venv already runs. - build_stream nft: the parse_catalog conftest and the invalid-config artifact store test no longer write fixed /tmp paths into their config; they use pytest's tmp_path / the test's temporary directory. - system_test dataset_edit.py: mark the CSV writer as not spreadsheet output (read by the orchestrator). Signed-off-by: balajikumaran-c-s <balajikumaran.cs@dell.com>
setup_svt_project.py printed the CI variable NAME (for example MULTISUBNET_SVT_TARGET_PASS), never its value, but the name came from a constant called PASSWORD_VAR, which CodeQL's name-based rule reads as a password flowing into print(). Rename the constant to OIM_LOGIN_VAR; the messages, the prompt and the API calls are unchanged. Signed-off-by: balajikumaran-c-s <balajikumaran.cs@dell.com>
Collaborator
|
LGTM. Well-implemented features with comprehensive validation, excellent backward compatibility, and good test hygiene improvements. Minor suggestion: Consider adding a comment in the header-only and files indicating they are templates and should be edited before use (e.g., "# This is a template file for PowerScale CSI driver secrets. Edit this file with your actual PowerScale credentials before deployment."). |
abhishek-sa1
approved these changes
Nov 16, 2026
abhishek-sa1
left a comment
Collaborator
There was a problem hiding this comment.
Approved. This PR adds well-implemented SVT capabilities (discovery cleanup, PowerVault config, PowerScale CSI file staging, per-cluster inputs) with comprehensive validation, excellent backward compatibility, and good test hygiene. No production code changes, no security concerns.
Rajeshkumar-s2
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
feat(system_test): SVT discovery cleanup, PowerVault and PowerScale CSI inputs, per-cluster inputs file
Description of the Solution
The SVT (
test/system_test) could not clean up discovery, build a PowerVault, place the PowerScale CSI files, or let a cluster pick its inputs file. This PR adds all four: a discovery cleanup step, apowervault_configgenerated from three user values, afilessetup step that stages the PowerScalesecret.yamlandvalues.yamlonly when the CSI is enabled, and a per-cluster<CLUSTER>_SVT_USER_INPUTSvariable. It changes test code and documentation only; nothing undersrc/is touched.Related Issue
Changes
Discovery cleanup (
test/system_test/library/vars/theme_vars.py,build_stream_test_config.yml)fvt_discovery cleanup test, after the orchestrator and beforeimage_build_manager. It runs only when discovery holds deployed state (a file under<data>/discovery/outputorlog), like telemetry; otherwise it is skipped and the log says why.cleanup.discoveryhas onlyenabled: discovery's credential and log options are playbook variables set by its own cleanup tests.PowerVault (
test/system_test/dataset_generator/dataset_merge.py,user_inputs.yml)orchestrator.storage_config.powervault_configasks forip(a list or comma separated),iscsi_initiatorandvolume_id; the generator holds the other defaults (port 3260,/mnt/slurm, xfs, per-host bind directories,slurm_control_node). A key added to the item overrides its default; an unknown key is an error.ipthere is no PowerVault: the item is ignored and a block from an earlier run is removed. With anip, the other two are required.storage_config.ymlhas the block only as a comment, so the generator creates the key and merges the item like any list item. The comment inuser_inputs.ymlexplains how the volume is mounted on the nodes.ib_addr_modeno longer fails once the key was removed.PowerScale CSI (
test/system_test/library/functions/setup_func.py,_setup.py,setup_env.sh,pipeline/*)files(./setup_env.sh --stage-files; last step of a run with no action; run by the pipeline's initialization job after the credentials). It copiessecret.yamlandvalues.yamlto the paths inomnia_config.ymlonly whenenable_powerscale_csiis true, after the install because the clean reinstall deletes that folder.$NAME/${NAME}ofomnia.env(default$ORCHESTRATOR_DATA_PATH/input/$OMNIA_PROJECT_NAME/..., the orchestrator project input folder); an unknown variable stops the run and is named.setup_svt_project.py --createseeds each cluster folder of the GitLab project with the product's reference examples (src/orchestrator/examples/powerscale_reference_files/CSI_driver/). They are added only when missing and--update-inputsnever replaces them. The checkout job copies the project's files next touser_inputs.yml(mode 0600, content on stdin only).secret.yaml.Inputs file per cluster (
test/system_test/pipeline/svt_ci.py,svt_pipeline_config.yml)svt.user_inputsper cluster (defaultuser_inputs.yml) becomes the CI/CD variable<CLUSTER>_SVT_USER_INPUTS. The checkout job copies the chosen file to the OIM asuser_inputs.yml. The name must be a plain.yml/.yamlfile name; a bad name or a file that is not in the project fails before anything on the OIM is touched.Test hygiene (
test/system_test/requirements.txt,test/build_stream/nft/unit/...,dataset_edit.py,pipeline/setup_svt_project.py)requirements.txtuses exact versions (pytest 9.2.0, pytest-order 1.5.0, PyYAML 6.0.3, ruamel.yaml 0.19.1), the ones the other suites pin and the SVT venv already runs.build_streamtests no longer write fixed/tmppaths into their config (they usetmp_path/ the test's temporary directory).dataset_edit.pyis marked# nosec(PXE inventory read by the orchestrator).PASSWORD_VARis renamedOIM_LOGIN_VAR(it holds a CI variable name; output and API calls are unchanged), so CodeQL's name-based rule no longer reads it as a password.Documentation (
test/system_test/README.md,docs/*,pipeline/README.md)filesstep, and the per-cluster inputs file.Files Changed
test/system_test/library/vars/theme_vars.pytest/system_test/build_stream_test_config.ymlcleanup.discoveryblock and cleanup ordertest/system_test/dataset_generator/dataset_merge.py$NAMEpath expansion, emptyib_addr_modererun fixtest/system_test/dataset_generator/dataset_publish.pyomnia.envto the path expansiontest/system_test/dataset_generator/dataset_edit.py# nosecon the CSV writertest/system_test/library/functions/setup_func.pystage_filesstep and its checkstest/system_test/library/messages/svt_msgs.pyfilessteptest/system_test/library/vars/common_vars.pyfilesaction and step, PowerScale constantstest/system_test/_setup.pyfilessteptest/system_test/setup_env.sh--stage-filesoptiontest/system_test/pipeline/svt_ci.py--stage-filesafter the credentialstest/system_test/pipeline/setup_svt_project.pysvt.user_inputsvariable, seeding of the reference examples, constant renametest/system_test/pipeline/svt_pipeline_config.ymlsvt.user_inputskey per clustertest/system_test/user_inputs.ymltest/system_test/requirements.txttest/build_stream/nft/unit/api/parse_catalog/conftest.pytmp_pathtest/build_stream/nft/unit/infra/artifact_store/test_file_artifact_store.pytest/system_test/README.mdtest/system_test/pipeline/README.mdtest/system_test/docs/SETUP.md--stage-filestest/system_test/docs/PIPELINE.mdtest/system_test/docs/PIPELINE_CONFIG.mduser_inputssetting and variabletest/system_test/docs/RUNNER.mdtest/system_test/docs/TEST_CONFIG.mdTesting
Run:
upstream/stagingtree: PowerVault with a list and with a comma separatedip, noip(ignored), rerun unchanged, an earlier block removed, anipwithoutiscsi_initiator/volume_id, an unknown key, an override; the output passes the orchestrator'sstorage_config.jsonschema and matches the live multisubnet PowerVault entry field by field. PowerScale paths with the default, a customOMNIA_DATA_PATH/OMNIA_PROJECT_NAME, rerun unchanged, and an unknown variable (error).filesstep with temporary folders: disabled and no cluster (skipped), both files edited (copied, mode 0600, an existing encrypted copy replaced), and each failure (missing file, unedited reference example, invalid YAML, empty/relative/..path, same path, missing folder), with the error text checked.--createseeding returns the two reference examples per cluster byte for byte.svt_ci.pywith a mocked remote: inputs file default, empty, named, missing,../, absolute and non-YAML names (all failures happen before any remote command); secret content only on stdin; the initialization order is configure, install, credentials,--stage-files, stage.build_streamtest areas: 29 passed, 2 skipped (named skips, unrelated).secure_code_review.pyovertest/system_testandtest/build_stream; remaining hits were checked and are false positives or the explicitSVT_SSH_SKIP_HOST_KEYopt-out.Not run:
fvt_discovery cleanup test, the PowerVault mount on nodes and the PowerScale deployment are not exercised.banditnot run locally.e171cf7cb): all 15 checks pass, including "Validate linked issue and IP policy", Bandit, Ansible Lint, Secure Code Review, Unit Tests & Coverage and Scan for secrets.Backward Compatibility
build_stream_test_config.ymlwithoutcleanup.discoverydefaults to enabled (the step still runs only with discovery state), an empty<CLUSTER>_SVT_USER_INPUTSmeansuser_inputs.yml, and without PowerScale files, or withenable_powerscale_csi: false, the new step is skipped.user_inputs.ymlwithoutpowervault_config, or with an emptyip, leavesstorage_config.ymluntouched.svt_ci.pyneeds an OIM checkout that has--stage-files(this PR); an older checkout fails at that step withUnknown option: --stage-files.enable_powerscale_csi: falseand$-based default paths.Suggested Reviewers
@abhishek-sa1@Rajeshkumar-s2svt_ci.py, GitLab variables), PowerScale and PowerVault inputs@snarthan