Repository navigation
Check config file close errors - #1
Merged
Merged
Conversation
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The scheduled CI workflow fails its Code Lint Scan because golangci-lint reports an unchecked
file.Close()return value inconvert/loadConfig.Discussion
The configuration loader deferred
file.Close()without checking the returned error. This caused theerrchecklinter to fail every scheduled CI run even though the other scan jobs passed. Ignoring the error could also hide a filesystem failure that occurs while closing the configuration file. When decoding and closing both fail, callers need access to both errors instead of losing either one.Recommendation
Check the close result, return it when it is the only failure, and combine it with a decode failure using
errors.Join. Add focused tests for both close-error paths.