Repository navigation
DM-4388: send a project on create, with a client-wide default_project - #57
Merged
jiatolentino merged 1 commit intoOct 22, 2026
Merged
Conversation
jiatolentino
marked this pull request as ready for review
October 15, 2026 10:54
jiatolentino
force-pushed
the
DM-4388-send-project-on-create
branch
from
October 16, 2026 00:32
57141ab to
4e550e9
Compare
jiatolentino
changed the base branch from
DM-3624-model-project-field
to
epic/DM-4993-projects-ui
October 16, 2026 00:33
carlosfunk
reviewed
Oct 19, 2026
carlosfunk
requested changes
Oct 19, 2026
jiatolentino
force-pushed
the
DM-4388-send-project-on-create
branch
from
October 19, 2026 05:59
4e550e9 to
d3d0e80
Compare
carlosfunk
approved these changes
Oct 19, 2026
jiatolentino
force-pushed
the
DM-4388-send-project-on-create
branch
from
October 20, 2026 05:48
d3d0e80 to
6a2e4cc
Compare
elliotsimpson-dm
force-pushed
the
epic/DM-4993-projects-ui
branch
from
October 22, 2026 02:10
5d2de36 to
3790427
Compare
`DataMasqueInstanceConfig.default_project` names the project a create goes into when its model has no `project`. Every create of a connection, ruleset, discovery config, RG config, table reference or library sends it, and `create_or_update_*` looks for an existing resource in it, before falling back to the server's only active project. Updating a connection leaves it in its project.
jiatolentino
force-pushed
the
DM-4388-send-project-on-create
branch
from
October 22, 2026 04:02
6a2e4cc to
38964bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets the projects UI epic, which has #55 and #56. TestPyPI build:
1.7.0.dev3.Why
A DataMasque server with several active projects can reject a create that names no project, and the client has no way to name one.
What
DataMasqueInstanceConfig.default_project: a<id>-<slug>reference such as1-default, or a bare id.project, ordefault_projectwhen that is unset. With neither set, nothing is sent, as before.upload_fileandupload_file_if_not_existstake aprojectargument with the same default.namespace.Testing
uv run pytest: 612 passed. Ruff, mypy,uv lock --checkand the docs build are clean.Defaultthroughdefault_project.