Repository navigation
Conversation
Amazon DocumentDB engine versions before 8.0.2 reject retryable writes, so `DocumentDbConnectionConfig` now defaults `retry_writes` to False, as `CosmosDbConnectionConfig` does. The value is always sent for DocumentDB, even when it equals the default. Some server versions store true for a DocumentDB connection that leaves the field out, and DocumentDB then rejects the run-history insert.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amazon DocumentDB engine versions before 8.0.2 reject retryable writes.
DocumentDbConnectionConfiginheritedretry_writes = TruefromMongoConnectionConfig, so a DocumentDB connection created with the SDK defaulted to retryable writes on, and DocumentDB rejected the run-history insert.Changes
DocumentDbConnectionConfigdefaultsretry_writestoFalse, asCosmosDbConnectionConfigdoes.retry_writesis always sent for DocumentDB, even when it equals the default. Some server versions storetruefor a DocumentDB connection that leaves the field out, so pruning the default would not be safe.retry_writeswhen it equals their own default.Testing
make test: 550 passed.make lint: ruff, ruff format and mypy are clean.