Skip to content

fix(auth): reject unreadable assistant headers instead of raising #1478 - #1480

Open
borealisalastor-byte wants to merge 1 commit into
dataease:mainfrom
borealisalastor-byte:fix/assistant-cert-headers
Open

borealisalastor-byte wants to merge 1 commit into
dataease:mainfrom
borealisalastor-byte:fix/assistant-cert-headers

Conversation

@borealisalastor-byte

Copy link
Copy Markdown
Contributor

common/core/deps.py::get_current_assistant 读取 X-SQLBOT-ASSISTANT-CERTIFICATE / X-SQLBOT-ASSISTANT-ONLINE 时直接写到 request.state.assistant 上,没有判断这个助手身份是否存在:

  • 请求用普通用户 token 认证(中间件不会写入 request.state.assistant)却带上证书头时,base_assistant 为 None,赋值抛 AttributeError → 500;
  • 头内容不是合法 base64,或解出的字节不是 UTF-8 时,b64decode / decode 抛错 → 同样 500。

改动

  • 助手身份缺失时按函数返回类型直接返回 None,不再写属性;
  • 证书解码失败抛 400(invalid assistant certificate),避免把客户端输入错误变成 500;
  • online 头逻辑等价改写,去掉一次多余的下标取值。

验证(cd backend 后执行)

  • pytest -q tests/test_assistant_request_headers.py → 修复前 4 failed / 2 passed,修复后 6 passed
    • 覆盖:无助手身份 + 证书头 → None;无助手身份 + online 头 → None;证书正常解码并 unquote;TRUE 归一为 True;非法 base64(A)与非 UTF-8 内容(//4=)→ 400
  • pytest -q tests --continue-on-collection-errors → 383 passed;仅 test_model_discovery.py::test_real_route_permission_and_safe_error 因本机缺少 sqlbot_xpack 失败,与改动无关

Fixes #1478

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 缺少助手身份时携带 X-SQLBOT-ASSISTANT-CERTIFICATE 头会抛 AttributeError(500)

1 participant