Skip to content

fix(pagination): clamp out-of-range page and size #1476 - #1477

Open
borealisalastor-byte wants to merge 1 commit into
dataease:mainfrom
borealisalastor-byte:fix/pagination-args
Open

borealisalastor-byte wants to merge 1 commit into
dataease:mainfrom
borealisalastor-byte:fix/pagination-args

Conversation

@borealisalastor-byte

Copy link
Copy Markdown
Contributor

pageNum/pageSize 路径参数直接进入 PaginationParams,Paginator 对两者都没有边界检查:

  • pageSize=0:(total + size - 1) // size 抛 ZeroDivisionError,列表接口返回 500;
  • pageNum=0:offset = (page - 1) * size 为 -size,PostgreSQL 报 OFFSET must not be negative,同样是 500;
  • pageSize 无上限:pageSize=100000 会让一次列表请求构造超大查询。

/system/user/pager/{pageNum}/{pageSize}、system/workspace 成员列表、system_variable 等接口都直接构造 PaginationParams,因此都会命中。

改动

新增 normalize_page_args,在 Paginator.paginate 与 Paginator.get_paginated_response 入口归一化:page < 1 → 1、size < 1 → 20、size > 500 → 500;归一化后的值用于 offset、total_pages 和响应里的 page/size。合法入参的行为不变。

验证(cd backend 后执行,无需数据库)

  • pytest -q tests/test_pagination_arguments.py → 5 passed(修复前该场景直接 ZeroDivisionError)
  • 修复前后对照:size=0 由抛异常变为返回第 1 页、size=20、total_pages=3;page=0 的响应 page 由 0 修正为 1,offset 不再为负;size=100000 收敛为 500
  • pytest -q tests --continue-on-collection-errors → 373 passed;仅 test_model_discovery.py::test_real_route_permission_and_safe_error 因本机缺少 sqlbot_xpack 失败,与改动无关

Fixes #1476

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 分页接口未校验 page/size:size=0 触发除零 500,page=0 产生负 OFFSET

1 participant