Skip to content

Release completed CloudFetch body-reader listeners - #634

Draft
vuanhphung wants to merge 3 commits into
mainfrom
perf/result-memory
Draft

vuanhphung wants to merge 3 commits into
mainfrom
perf/result-memory

Conversation

@vuanhphung

Copy link
Copy Markdown
Collaborator

Completed Thrift CloudFetch bodies remain reachable from idle TLS sockets through node-fetch's body-reader listeners and settled promises. A live post-drain heap snapshot attributes 154.7 MB of large backing stores to that path after a 216 MB read.

Remove only the listeners installed by each body read once it settles, preserving earlier/later listeners and late-error handling. This builds on #627's Buffer reuse; it does not change concurrency, retries, telemetry, values or defaults. Kernel downloading is native and does not use node-fetch.

Verification in progress: 30 focused tests pass, including regressions that fail on #627. Rotated five-run live main/#627/branch measurements, full checks and backend e2e are running. Isolated pre-implementation probe: five concurrent 400 MB reads used 2622 → 1424 MiB peak RSS; final branch numbers pending.

Adversarial review: pending; keep draft. Depends on #627 landing first.

This pull request and its description were written by Isaac.

vuanhphung and others added 3 commits November 19, 2026 15:44
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Detach only the listeners installed by node-fetch after each body read settles, preserving other listeners and late-error handling.

Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>

This branch was successfully deployed

1 active deployment
azure-prod — 36ee05a7 Deployed Nov 19, 2026 by vuanhphung via e2e-test (24.22.1, 24_22_1) #2151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant