Repository navigation
Release completed CloudFetch body-reader listeners - #634
Draft
vuanhphung wants to merge 3 commits into
Draft
vuanhphung wants to merge 3 commits into
vuanhphung wants to merge 3 commits into
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
Detach only the listeners installed by node-fetch after each body read settles, preserving other listeners and late-error handling. Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed Thrift CloudFetch bodies remain reachable from idle TLS sockets through node-fetch's body-reader listeners and settled promises. A live post-drain heap snapshot attributes 154.7 MB of large backing stores to that path after a 216 MB read.
Remove only the listeners installed by each body read once it settles, preserving earlier/later listeners and late-error handling. This builds on #627's Buffer reuse; it does not change concurrency, retries, telemetry, values or defaults. Kernel downloading is native and does not use node-fetch.
Verification in progress: 30 focused tests pass, including regressions that fail on #627. Rotated five-run live main/#627/branch measurements, full checks and backend e2e are running. Isolated pre-implementation probe: five concurrent 400 MB reads used 2622 → 1424 MiB peak RSS; final branch numbers pending.
Adversarial review: pending; keep draft. Depends on #627 landing first.
This pull request and its description were written by Isaac.