Repository navigation
Avoid decimal strings for safe Arrow decimal values - #633
Draft
vuanhphung wants to merge 1 commit into
Draft
vuanhphung wants to merge 1 commit into
vuanhphung wants to merge 1 commit into
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #628 (
perf/row-convert); retarget tomainafter it merges.Arrow Decimal128 → number currently formats an intermediate decimal string for every value. Profiles attribute 60% of decoded mixed-batch time and 6.67 seconds of a live kernel lineitem 2M run to this conversion.
Read the unscaled integer directly from its existing 32-bit words only when the upper words are valid sign extensions and the result is exactly representable. Keep the original conversion for larger values and precision-preserving output. The shared helper also covers nested/legacy rows; BIGINT, IPC, defaults, logging and telemetry are unchanged.
Verification: 42 focused unit tests and static checks pass; full-unit environment issue reproduces on main. Five interleaved fresh-process pairs on Node 24.22.1, decoded batches (no network):
Live paired results and complete correctness checks are in progress. Factory reproduction scripts and raw runs are in
~/factory/harness/and~/factory/runs/; full handoff will be in~/factory/perf-evidence.md.Adversarial review: pending independent factory review; keep this PR in draft.
This pull request and its description were written by Isaac.