Repository navigation
Reuse feature-flag responses across connections to the same host - #630
Open
vuanhphung wants to merge 5 commits into
Open
vuanhphung wants to merge 5 commits into
vuanhphung wants to merge 5 commits into
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
vuanhphung
had a problem deploying
to
azure-prod
November 19, 2026 07:29 — with
GitHub Actions
Failure
vuanhphung
had a problem deploying
to
azure-prod
November 19, 2026 07:29 — with
GitHub Actions
Failure
vuanhphung
had a problem deploying
to
azure-prod
November 19, 2026 07:29 — with
GitHub Actions
Failure
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
vuanhphung
had a problem deploying
to
azure-prod
November 19, 2026 08:36 — with
GitHub Actions
Failure
vuanhphung
had a problem deploying
to
azure-prod
November 19, 2026 08:36 — with
GitHub Actions
Failure
vuanhphung
had a problem deploying
to
azure-prod
November 19, 2026 08:36 — with
GitHub Actions
Failure
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 Low
Looks good, with 1 low concern. Idle retention, expiry on the monotonic clock, the LRU bound, and coalescing of in-flight fetches are correct, and the tests cover them. Nit: the CHANGELOG entry is a loose paragraph rather than a bullet with a PR reference like its neighbours.
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every sequential Thrift reconnect refetches flags after the last client closes. Five rotated A/B runs measure 30 GETs per 30 reconnects and paired connect+openSession p50 186.94 -> 134.36 ms (28% faster). Skipping that GET moves a TLS handshake into the first OpenSession, so CONNECTION_OPEN operation_latency_ms p50 rises 65 -> 134 ms for sequential reconnects despite faster total setup; notify Node.js telemetry dashboard owners before release.
Keep main's sharing key unchanged (workspace org-id, otherwise normalized host), including active-request coalescing across auth types and SPOG hosts. Retain up to 100 idle successful responses for every auth type until their original monotonic expiry, without retaining credentials, connections or timers; successful responses without a valid TTL use the 15-minute default, while failures preserve shorter retry windows. The live TTL is 3600 s, so a server-side flag flip can take up to an hour to reach a reconnecting app, the same as a long-lived client on main.
Local verification: 1,836 unit tests, 29 live Thrift/kernel e2e tests plus a warm-suite isolation repro, lint/format/types/build, typed/null/limit/cancel checksums, and 1,000-cycle 64-MiB-heap lifecycle checks pass. OAuth mock runs substitute credentials, not real grants; live external-token runs use the issued token.
Adversarial review: converged in two rounds; bot re-review approved with no issues after fixing its one Low finding and changelog nit.
This pull request and its description were written by Isaac.