Repository navigation
feat(kernel): expose HTTP/2 opt-out #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f9cec83
2c358c5
4fb6fa0
f3e4ce5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -238,6 +238,7 @@ export interface KernelTlsOptions { | |
| * the kernel folds last-wins). | ||
| */ | ||
| export interface KernelHttpOptions { | ||
| enableHttp2?: boolean; | ||
| customHeaders?: Array<{ name: string; value: string }>; | ||
| socketTimeoutMs?: number; | ||
| } | ||
|
|
@@ -523,6 +524,12 @@ export function buildKernelHttpOptions(options: ConnectionOptions): KernelHttpOp | |
| headers.push({ name: 'User-Agent', value: buildUserAgentString(userAgentEntry) }); | ||
|
|
||
| const http: KernelHttpOptions = { customHeaders: headers }; | ||
| if (options.enableHttp2 !== undefined) { | ||
| if (typeof options.enableHttp2 !== 'boolean') { | ||
| throw new HiveDriverError('kernel backend: `enableHttp2` must be a boolean.'); | ||
| } | ||
| http.enableHttp2 = options.enableHttp2; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 High — 🔀 Found by Claude Opus 5.5 · confirmed by the judge |
||
| } | ||
| // Per-connection socket read timeout (ms). The public `socketTimeout` | ||
| // ConnectionOption maps onto the kernel napi `socketTimeoutMs` | ||
| // (kernel `HttpConfig::request_timeout` / reqwest `Client::timeout`). | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium — The changelog claims HTTP/2 negotiation and
enableHttp2: falsework, but the platform packages are pinned to 1.4.0, which has no such field in this diff. Add the published-package caveat and the kernel change reference, or land the pin bump with the entry.🔀 Found by Claude Opus 5.5 · confirmed by the judge